chore: remove most transport overrides from GAPIC options#16779
Closed
jskeet wants to merge 1 commit intogoogleapis:mainfrom
Closed
chore: remove most transport overrides from GAPIC options#16779jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Compute is still specified, as that needs a fix in sdk.yaml (ongoing). Towards googleapis/librarian#5542
Contributor
Author
|
I've regenerated with this config, and there are no additional changes. I've created this as a draft PR, as we'll want to land #16762 first to avoid conflicts. (It's easy to recreate this PR afterwards, even if rebasing doesn't work.) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes explicit transport configurations and opt_args_by_api blocks for various Google Cloud Python libraries within librarian.yaml, including BigQuery Data Policies, Billing Budgets, Container, Firestore, IAM, Notebooks, TPU, Video Intelligence, and Workflows. I have no feedback to provide.
Contributor
Author
|
Closing this PR so I can do the same thing in a new PR now that explicit options have been merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute is still specified, as that needs a fix in sdk.yaml (ongoing).
Towards googleapis/librarian#5542