chore: complete migration of google-cloud-datacatalog-lineage-configmanagement#16784
chore: complete migration of google-cloud-datacatalog-lineage-configmanagement#16784parthea merged 1 commit intogoogleapis:mainfrom
Conversation
…anagement This has more changes than other packages because it hadn't been regenerated with the newest legacylibrarian (that updated the Python version requirements, for example). Fixes googleapis/librarian#5337
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the library to support Python 3.9+ and drops support for Python 3.7 and 3.8. Key changes include updating dependency versions for google-api-core and protobuf, adding an api_audience parameter to transport constructors, and improving request handling in client methods to support dictionary inputs. The test suite has also been updated to reflect these changes and adopt modern Python features. A critical issue was identified in noxfile.py where the google-auth source URL was incorrectly changed to point to the google-cloud-python repository instead of its dedicated repository.
| "googleapis-common-protos @ git+https://github.com/googleapis/google-cloud-python#egg=googleapis-common-protos&subdirectory=packages/googleapis-common-protos", | ||
| "google-api-core @ git+https://github.com/googleapis/google-cloud-python#egg=google-api-core&subdirectory=packages/google-api-core", | ||
| "google-auth @ git+https://github.com/googleapis/google-auth-library-python.git", | ||
| "google-auth @ git+https://github.com/googleapis/google-cloud-python#egg=google-auth&subdirectory=packages/google-auth", |
There was a problem hiding this comment.
The URL for google-auth is incorrect. google-auth is maintained in its own repository (googleapis/google-auth-library-python) and is not part of the google-cloud-python mono-repo. This change will cause the core_deps_from_source session to fail as it will not find the package in the specified subdirectory.
| "google-auth @ git+https://github.com/googleapis/google-cloud-python#egg=google-auth&subdirectory=packages/google-auth", | |
| "google-auth @ git+https://github.com/googleapis/google-auth-library-python.git", |
2 participants
This has more changes than other packages because it hadn't been regenerated with the newest legacylibrarian (that updated the Python version requirements, for example).
Fixes googleapis/librarian#5337