Skip to content

chore: add suppress warning for TrustAllX509TrustManager since that is what the method is actually supposed to do #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add suppress warning for TrustAllX509TrustManager since that is what the method is actually supposed to do #2091

wants to merge 1 commit into from

Conversation

ldetmer
Copy link
Contributor

@ldetmer ldetmer commented Mar 28, 2025

This was flagged by android team as an issue when they take in our SDK

Fixes #1866

@ldetmer
chore: add suppress warning for TrustAllX509TrustManager since that i…
538ebe3 
…s what the method is actually supposed to do
@ldetmer ldetmer requested a review from a team as a code owner March 28, 2025 12:40
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 28, 2025
@ldetmer ldetmer requested a review from diegomarquezp March 28, 2025 12:40
@paulthomson
Copy link

Note that @SuppressWarnings only has source retention, so it will not make it to the bytecode jar library, and so Android Lint will still potentially report a warning for any developers that use this library in their Android app.

For this reason, Android Lint only looks for @SuppressLint in the bytecode. It can come from any package, so you may want to just create your own SuppressLint annotation (see internal bug for example).

@ldetmer ldetmer mentioned this pull request Mar 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldetmer @paulthomson