chore(deps): update dependency com.google.cloud:google-cloud-bigquery-parent to v2.58.0-rc1 #4038
Conversation
…-parent to v2.58.0-rc1
product-auto-label
bot
added
size: xs
|
/gcbrun |
trusted-contributions-gcf
bot
added
the
kokoro:force-run
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
yoshi-kokoro
removed
the
kokoro:force-run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to update the google-cloud-bigquery-parent dependency to version 2.58.0-rc1. However, the changes are incorrect for this multi-module Maven project. The PR only modifies the parent version in the benchmark and google-cloud-bigquery modules, but fails to update the version of the parent POM itself, which is defined in the root pom.xml. This inconsistency will break the build. The version update needs to be applied consistently across all relevant pom.xml files in the repository.
| <artifactId>google-cloud-bigquery-parent</artifactId> | ||
| <groupId>com.google.cloud</groupId> | ||
| <version>2.57.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquery:current} --> | ||
| <version>2.58.0-rc1</version><!-- {x-version-update:google-cloud-bigquery:current} --> |
There was a problem hiding this comment.
Updating the parent version to 2.58.0-rc1 here is incorrect because the parent POM (google-cloud-bigquery-parent) is part of this same multi-module project. The version of the parent is defined in the root pom.xml and has not been updated from 2.57.2-SNAPSHOT. This inconsistency will cause the build to fail. All modules in this project should be versioned consistently.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-bigquery-parent</artifactId> | ||
| <version>2.57.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquery:current} --> | ||
| <version>2.58.0-rc1</version><!-- {x-version-update:google-cloud-bigquery:current} --> |
There was a problem hiding this comment.
This parent version update is incorrect for a multi-module project where the parent is defined within the same repository. The root pom.xml still defines google-cloud-bigquery-parent with version 2.57.2-SNAPSHOT. This change will break the Maven build. The version update should be applied to the parent pom.xml and propagated to all modules consistently.
3 participants
This PR contains the following updates:
2.57.2-SNAPSHOT->2.58.0-rc1Release Notes
googleapis/java-bigquery (com.google.cloud:google-cloud-bigquery-parent)
v2.58.0-rc1Compare Source
Features
java.timemethods and variables (#3586) (31fb15f)Bug Fixes
Dependencies
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.