fix: Fix README.md Default value for maxBufferBytes #412
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the code the current Default value for maxBufferBytes is 9500000L (DEFAULT_MAX_BUFFER_BYTES) (https://github.com/googleapis/java-pubsub-group-kafka-connector/blob/main/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkConnector.java#L53) 9500000L is also the max value that can be used. Fix [411](googleapis#411)
DanielssonJacob
force-pushed
the
maxBufferBytes-default-value
branch
from
45b9d3e to
77eb0fc
Compare
matt-kwong
approved these changes
Dec 16, 2025
dsaheb
approved these changes
Dec 16, 2025
matt-kwong
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the code the current Default value for maxBufferBytes is 9500000L (DEFAULT_MAX_BUFFER_BYTES) (https://github.com/googleapis/java-pubsub-group-kafka-connector/blob/main/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubSinkConnector.java#L53) 9500000L is also the max value that can be used.
Fix 411