chore(samples): Move inline data to be hosted on githbub repo for graphrag notebook #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: spanner
amullick-git
changed the title
averikitsch
reviewed
Mar 21, 2025
docs/graph_rag.ipynb
Outdated
| "* Quick-drying surface prevents smudging\n", | ||
| "\n", | ||
| "Specifications:\n", | ||
| "!git clone https://github.com/amullick-git/retail_data\n", |
There was a problem hiding this comment.
I would recommend not linking out to other repos and storing the data directly in this repo, either in the docs/ or samples/ directory like retail_data/data.zip.
Then you can call in a code block before this one:
!wget https://github.com/googleapis/langchain-google-spanner-python/blob/main/samples/retail_data/data.zip
!unzip /content/data.zip
Then you can continue with the loading from the directory.
There was a problem hiding this comment.
Thank you for the suggestion. Made the change with slight modifications.
averikitsch
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕