feat(internal/sidekick/rust): add helper functions for annotation list fields#4915
Open
perashanid wants to merge 1 commit intogoogleapis:mainfrom
Open
feat(internal/sidekick/rust): add helper functions for annotation list fields#4915perashanid wants to merge 1 commit intogoogleapis:mainfrom
perashanid wants to merge 1 commit intogoogleapis:mainfrom
Conversation
…t fields Add helper functions to check if list fields are non-empty in annotation structs, replacing the need for duplicate boolean fields in templates. This makes templates cleaner and reduces opportunities for mistakes. Helper functions added: - modelAnnotations: HasRequiredPackages, HasExternPackages, HasDisabledRustdocWarnings, HasDisabledClippyWarnings, HasDefaultSystemParameters, HasDefaultFeatures, HasExtraModules - methodAnnotation: HasSystemParameters, HasAttributes - pathBindingAnnotation: HasQueryParams, HasSubstitutions - pathInfoAnnotation: HasUniqueParameters - discoveryLroAnnotations: HasPollingPathParameters - fieldAnnotations: HasOtherFieldsInGroup Fixes googleapis#1603
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several helper methods to structs in internal/sidekick/rust/annotate.go to check for non-empty slices or maps using a Has naming convention. A review comment points out that the new HasSubstitutions method duplicates the existing HasVariablePath method and recommends consolidating them to avoid redundancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds helper functions to annotation structs in the Rust sidekick generator to check if list fields are non-empty. This eliminates the need for duplicate boolean fields in templates, making them cleaner and reducing opportunities for mistakes.
Changes Made:
Technical Implementation:
Following the existing pattern in the codebase (e.g., HasServices(), HasLROs(), HasBindings()), each helper function returns true if the corresponding list field has a non-zero length. These functions can be used in mustache templates to conditionally render sections based on whether lists are populated.
Testing:
Fixes #1603