feat(internal/librarian/java): generate module level parent and bom pom if missing#4983
Merged
zhumin8 merged 12 commits intogoogleapis:mainfrom Apr 1, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the generation of BOM and Parent POM files for Java libraries. Key changes include refactoring the POM generation logic to support these new modules, updating data structures to include versioning, and adding helper functions for monorepo version lookup and group ID determination. A review comment suggests using the rootLibrary constant in an error message instead of a hardcoded string to improve maintainability.
JoeWang1127
reviewed
Apr 1, 2026
JoeWang1127
approved these changes
Apr 1, 2026
Contributor
JoeWang1127
left a comment
JoeWang1127
left a comment
There was a problem hiding this comment.
Left some comments on the tests and doc, feel free to refactor in a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support generate module level parent and bom pom.xml files from template if missing. Also fixed proto- and grpc- module groupId.
For #4922