Skip to content

feat(sidekick/swift): bootstrap the codec#4989

Merged
coryan merged 3 commits intogoogleapis:mainfrom
coryan:impl-sidekick-swift-bootstrap
Apr 1, 2026
Merged

feat(sidekick/swift): bootstrap the codec#4989
coryan merged 3 commits intogoogleapis:mainfrom
coryan:impl-sidekick-swift-bootstrap

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Apr 1, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Swift code generator and a README template. The review feedback recommends using the path/filepath package for OS-agnostic path manipulation, ensuring all I/O errors are handled using t.Fatal in tests, and avoiding package-level variable initialization that ignores errors.

@coryan coryan marked this pull request as ready for review April 1, 2026 21:00
@coryan coryan requested review from a team as code owners April 1, 2026 21:00
@coryan coryan merged commit 935693a into googleapis:main Apr 1, 2026
18 of 20 checks passed
@coryan coryan deleted the impl-sidekick-swift-bootstrap branch April 1, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants