refactor(internal/command): add Git and Cargo command name constants#4994
Open
julieqiu wants to merge 1 commit intogoogleapis:mainfrom
Open
refactor(internal/command): add Git and Cargo command name constants#4994julieqiu wants to merge 1 commit intogoogleapis:mainfrom
julieqiu wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Replace "git" and "cargo" with constants in the command package throughout the codebase.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Cargo and Git constants in the command package and replaces hardcoded strings with these constants throughout the codebase. Feedback suggests extending this refactoring to include the cfg.Tools key in the preFlight call for better consistency.
| return err | ||
| } | ||
| gitExe := command.GetExecutablePath(cfg.Preinstalled, "git") | ||
| gitExe := command.GetExecutablePath(cfg.Preinstalled, command.Git) |
Contributor
There was a problem hiding this comment.
For consistency with the rest of the PR, consider using the command.Cargo constant as the key for cfg.Tools when calling preFlight on line 68. Although line 68 is not directly modified in this hunk, it is part of the same logical block being refactored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "git" and "cargo" strings with constants in the command package throughout the codebase.