ci(.github): update Go integration and vet script#4999
Open
JoeWang1127 wants to merge 9 commits intomainfrom
Open
ci(.github): update Go integration and vet script#4999JoeWang1127 wants to merge 9 commits intomainfrom
JoeWang1127 wants to merge 9 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies Librarian to modernize the Go integration workflow by updating the vet.sh script to use
golangci-lintinstead of standalone tools.The
vet.shscript is updated to rungolangci-lintwith thereviveandstaticchecklinters.It now includes robust filtering for known upstream issues in google-cloud-go, ensuring that generation checks do not fail on pre-existing code.
Change detection for
go.modandgo.sumis improved usinggit diff --exit-code, and the script now uses temporary files for more reliable output verification.Fixes #4894
Fixes #4895