Skip to content

ci(.github): update Go integration and vet script#4999

Open
JoeWang1127 wants to merge 9 commits intomainfrom
chore/update-go-integration
Open

ci(.github): update Go integration and vet script#4999
JoeWang1127 wants to merge 9 commits intomainfrom
chore/update-go-integration

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Apr 2, 2026

This change modifies Librarian to modernize the Go integration workflow by updating the vet.sh script to use golangci-lint instead of standalone tools.

The vet.sh script is updated to run golangci-lint with the revive and staticcheck linters.
It now includes robust filtering for known upstream issues in google-cloud-go, ensuring that generation checks do not fail on pre-existing code.
Change detection for go.mod and go.sum is improved using git diff --exit-code, and the script now uses temporary files for more reliable output verification.

Fixes #4894
Fixes #4895

@JoeWang1127 JoeWang1127 changed the title Chore/update go integration chore(ci): update Go integration and vet script Apr 2, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the license URL in the .golangci.yaml file from http to https. I have no further feedback to provide as the change is straightforward and correct.

@JoeWang1127 JoeWang1127 changed the title chore(ci): update Go integration and vet script ci(.github): update Go integration and vet script Apr 2, 2026
@JoeWang1127 JoeWang1127 marked this pull request as ready for review April 2, 2026 01:36
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner April 2, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

golang: standardize static analysis tools across librarian and google-cloud-go golang: use golangci-lint for static checks and linters

1 participant