Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/librarian/java/repometadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ func deriveRepoMetadata(cfg *config.Config, library *config.Library, googleapisD
ProductDocumentation: sharedMetadata.ProductDocumentation,
APIDescription: sharedMetadata.APIDescription,
ReleaseLevel: sharedMetadata.ReleaseLevel,
Transport: sharedMetadata.Transport,
Language: config.LanguageJava,
Repo: sharedMetadata.Repo,
RepoShort: fmt.Sprintf("%s-%s", config.LanguageJava, library.Name),
Expand Down Expand Up @@ -157,5 +156,11 @@ func deriveRepoMetadata(cfg *config.Config, library *config.Library, googleapisD
artifactID := parts[len(parts)-1]
metadata.ClientDocumentation = fmt.Sprintf("https://cloud.google.com/java/docs/reference/%s/latest/overview", artifactID)
}
// transport
apiCfg, err := serviceconfig.Find(googleapisDir, library.APIs[0].Path, config.LanguageJava)
if err != nil {
return nil, fmt.Errorf("failed to find api config: %w", err)
}
metadata.Transport = apiCfg.RepoMetadataTransport(config.LanguageJava)
return metadata, nil
}
2 changes: 0 additions & 2 deletions internal/librarian/rust/generate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,6 @@ func TestCreateRepoMetadata(t *testing.T) {
APIDescription: "Stores sensitive data such as API keys, passwords, and certificates.\nProvides convenience while improving security.",
ReleaseLevel: "stable",
LibraryType: "GAPIC_AUTO",
Transport: "grpc+rest",
},
},
{
Expand Down Expand Up @@ -738,7 +737,6 @@ func TestCreateRepoMetadata(t *testing.T) {
APIShortname: "showcase",
ReleaseLevel: "stable",
LibraryType: "GAPIC_AUTO",
Transport: "grpc+rest",
},
},
} {
Expand Down
5 changes: 0 additions & 5 deletions internal/repometadata/repometadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ type RepoMetadata struct {

// Repo is the repository name (e.g., "googleapis/google-cloud-rust").
Repo string `json:"repo,omitempty"`

// Transport is the transport protocol
Transport string `json:"transport,omitempty"`
}

// FromLibrary creates a RepoMetadata from a specific library in a
Expand All @@ -109,7 +106,6 @@ type RepoMetadata struct {
// - ProductDocumentation
// - ReleaseLevel
// - Repo
// - Transport
//
// Any other fields required by the caller's language should be populated by the
// caller before writing to disk.
Expand Down Expand Up @@ -146,7 +142,6 @@ func fromAPI(config *config.Config, api *serviceconfig.API, library *config.Libr
ProductDocumentation: extractBaseProductURL(api.DocumentationURI),
ReleaseLevel: api.ReleaseLevel(config.Language),
Repo: config.Repo,
Transport: api.RepoMetadataTransport(config.Language),
}
}

Expand Down
2 changes: 0 additions & 2 deletions internal/repometadata/repometadata_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ func TestFromLibrary(t *testing.T) {
APIID: "secretmanager.googleapis.com",
APIShortname: "secretmanager",
APIDescription: "Stores sensitive data such as API keys, passwords, and certificates.\nProvides convenience while improving security.",
Transport: "grpc+rest",
},
},
{
Expand All @@ -70,7 +69,6 @@ func TestFromLibrary(t *testing.T) {
APIID: "secretmanager.googleapis.com",
APIShortname: "secretmanager",
APIDescription: "Stores, manages, and secures access to application secrets.",
Transport: "grpc+rest",
},
},
{
Expand Down
1 change: 0 additions & 1 deletion internal/sample/repometadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,5 @@ func RepoMetadata() *repometadata.RepoMetadata {
NamePretty: "Secret Manager",
ProductDocumentation: "https://cloud.google.com/secret-manager/",
ReleaseLevel: "stable",
Transport: "grpc+rest",
}
}
Loading