feat(librarian/swift): default output directory#5024
Conversation
Librarian needs to compute the default output directory for an API. For Swift, I am selecting the full path of the API, as we do in most languages. The `librarian.yaml` file will include a prefix, such as `generated/`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Swift language support to the librarian by implementing the DefaultOutput function and its associated tests. The review feedback focuses on improving code clarity by renaming parameters to match the API-centric naming used in other languages, ensuring Go documentation follows standard formatting conventions, and aligning the test suite with the project's style guide by utilizing cmp.Diff for assertions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds Swift support for default output path generation by implementing the DefaultOutput function and integrating it into the librarian's generation logic. The changes include a new swift package with associated unit tests. The review feedback recommends refactoring the table-driven tests to define the test cases directly within the loop range clause, consistent with the repository's Go style guide.
3 participants
Librarian needs to compute the default output directory for an API. For Swift, I am selecting the full path of the API, as we do in most languages. The
librarian.yamlfile will include a prefix, such asgenerated/.