feat(go): add NoSnippets to disable snippetgen#5027
Merged
noahdietz merged 4 commits intogoogleapis:mainfrom Apr 3, 2026
Merged
feat(go): add NoSnippets to disable snippetgen#5027noahdietz merged 4 commits intogoogleapis:mainfrom
noahdietz merged 4 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a NoSnippets configuration option to the GoAPI struct, allowing users to skip snippet generation. The implementation includes updating the GAPIC options to include omit-snippets, bypassing snippet movement and updates when the flag is set, and ensuring the isEmptyAPI check accounts for this new field. Corresponding test cases have been added to verify the behavior in TestBuildGAPICOpts, TestMoveGeneratedFiles, and TestIsEmptyAPI. I have no feedback to provide.
JoeWang1127
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go gapic generator has a flag -
omit-snippets- that disables snippet generation. Add aGoAPIpropertyNoSnippetsthat triggers the inclusion of this flag and disable librarian Go functionality related to moving snippets around (because they won't have been generated).This will be especially important for Previews bc we don't want Go snippets for preview clients, and
NoSnippets = truewill be a default applied to all Preview entries for Go.Fixes #5025