feat(internal/librarian): sync new libraries to legacy state.yaml#5030
Merged
JoeWang1127 merged 10 commits intomainfrom Apr 3, 2026
Merged
feat(internal/librarian): sync new libraries to legacy state.yaml#5030JoeWang1127 merged 10 commits intomainfrom
JoeWang1127 merged 10 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to synchronize the legacy .librarian/state.yaml configuration file when adding new libraries, specifically for Go. It adds the syncToStateYAML and createLegacyLibrary functions, along with corresponding unit tests. Review feedback suggests replacing a single-case switch statement with a more idiomatic if condition and notes that the APIs field should be populated in the legacy library state to maintain compatibility with tools relying on the legacy manifest.
julieqiu
reviewed
Apr 3, 2026
julieqiu
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The librarian add command is modified to automatically update the legacy
.librarian/state.yamlwhen a new library is added tolibrarian.yaml.This ensures that tools still relying on the legacy manifest remain in sync during the migration period. Only Go is enabled.
Fixes #5011