ci: add SLSA build provenance to docker images#2556
Conversation
Summary of ChangesHello @duwenxin99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the integrity and verifiability of the project's release artifacts. By adopting SLSA build provenance, it ensures that all generated binaries and Docker images come with cryptographically signed metadata detailing their build process. This change streamlines artifact storage and improves supply chain security without altering the core build logic. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Cloud Build release process to generate SLSA build provenance for release binaries and Docker images, replacing manual artifact storage with the artifacts block and updating go build commands for reproducibility. However, the implementation introduces a medium-severity path traversal vulnerability in a build script, where an attacker could manipulate a version file to compromise build integrity. Additionally, a critical issue in the new prepare-artifacts step could cause build failure, and there's an opportunity to improve script maintainability.
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
Ref: Generate Cloud Build provenance