feat(auth): add generic `authService` type for MCP by duwenxin99 · Pull Request #2619 · googleapis/mcp-toolbox

duwenxin99 · 2026-03-03T18:22:44Z

Add new generic authService type as part of the MCP auth implementation.

gemini-code-assist · 2026-03-03T18:22:59Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes the foundational structure for generic authentication services by adding a new Go package. This change aims to centralize and organize common authentication logic, paving the way for future implementation of various authentication methods.

Highlights

New Generic Auth Package: Introduced a new 'generic' package within 'internal/auth' to house common authentication service functionalities.

Changelog

internal/auth/generic/generic.go
- Created the initial 'generic.go' file with its package declaration.

Activity

No specific review comments or activity have been recorded yet for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request appears to be incomplete. The title feat(auth): add generic authServices suggests the implementation of a new generic authentication service, but the changes only consist of adding a new, nearly empty Go file. There is no implementation of the service itself. Please provide the full implementation for review.

internal/auth/generic/generic.go

github-actions · 2026-03-03T18:26:42Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

github-actions · 2026-03-04T17:56:19Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

internal/auth/generic/generic.go

github-actions · 2026-03-10T14:10:40Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

github-actions · 2026-03-10T14:30:19Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

internal/auth/generic/generic.go

github-actions · 2026-03-23T18:38:22Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

github-actions · 2026-03-23T18:46:42Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

github-actions · 2026-03-23T19:32:00Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

internal/auth/generic/generic.go

cmd/internal/tools_file_test.go

github-actions · 2026-03-25T20:07:24Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

github-actions · 2026-03-25T20:44:02Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2619/

github-actions · 2026-03-26T14:42:46Z

🚀 Cloudflare Preview Ready!

🔎 View Preview: https://pr-2619.toolbox-docs-6xc.pages.dev

(Note: Subsequent pushes to this PR will automatically update the preview at this same URL)

github-actions · 2026-03-26T17:12:58Z

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-2619 have been deleted.

github-actions · 2026-03-26T17:13:40Z

🧨 Preview deployments removed.

Add new generic `authService` type as part of the MCP auth implementation. f6678f8

…s#2619) Add new generic `authService` type as part of the MCP auth implementation. f6678f8

🤖 I have created a release *beep* *boop* --- ## [0.31.0](v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([#2831](#2831)) * **http:** sanitize non-2xx error output ([#2654](#2654)) * add a new `enable-api` flag ([#2846](#2846)) * remove deprecations and update tools-file flag ([#2806](#2806)) ### Features * Add a new `enable-api` flag ([#2846](#2846)) ([7a070da](7a070da)) * **auth:** Add generic `authService` type for MCP ([#2619](#2619)) ([f6678f8](f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([#2698](#2698)) ([b53dcf2](b53dcf2)) * **auth:** Support manual PRM override ([#2717](#2717)) ([283e4e3](283e4e3)) * **dataplex:** Add support for lookup context tool. ([#2744](#2744)) ([facb69d](facb69d)) * Remove deprecations and update tools-file flag ([#2806](#2806)) ([ab64c95](ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([#2859](#2859)) ([f8891b8](f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([#2853](#2853)) ([9ebd93a](9ebd93a)) * **http:** Sanitize non-2xx error output ([#2654](#2654)) ([5bef954](5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([#2847](#2847)) ([4564efe](4564efe)) ### Documentation * Release upgraded docsite ([#2831](#2831)) ([5b25ce0](5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.31.0](v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([#2831](#2831)) * **http:** sanitize non-2xx error output ([#2654](#2654)) * add a new `enable-api` flag ([#2846](#2846)) * remove deprecations and update tools-file flag ([#2806](#2806)) ### Features * Add a new `enable-api` flag ([#2846](#2846)) ([7a070da](7a070da)) * **auth:** Add generic `authService` type for MCP ([#2619](#2619)) ([f6678f8](f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([#2698](#2698)) ([b53dcf2](b53dcf2)) * **auth:** Support manual PRM override ([#2717](#2717)) ([283e4e3](283e4e3)) * **dataplex:** Add support for lookup context tool. ([#2744](#2744)) ([facb69d](facb69d)) * Remove deprecations and update tools-file flag ([#2806](#2806)) ([ab64c95](ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([#2859](#2859)) ([f8891b8](f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([#2853](#2853)) ([9ebd93a](9ebd93a)) * **http:** Sanitize non-2xx error output ([#2654](#2654)) ([5bef954](5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([#2847](#2847)) ([4564efe](4564efe)) ### Documentation * Release upgraded docsite ([#2831](#2831)) ([5b25ce0](5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c6b811c

🤖 I have created a release *beep* *boop* --- ## [0.31.0](googleapis/mcp-toolbox@v0.30.0...v0.31.0) (2026-03-26) ### ⚠ BREAKING CHANGES * release upgraded docsite ([googleapis#2831](googleapis#2831)) * **http:** sanitize non-2xx error output ([googleapis#2654](googleapis#2654)) * add a new `enable-api` flag ([googleapis#2846](googleapis#2846)) * remove deprecations and update tools-file flag ([googleapis#2806](googleapis#2806)) ### Features * Add a new `enable-api` flag ([googleapis#2846](googleapis#2846)) ([7a070da](googleapis@7a070da)) * **auth:** Add generic `authService` type for MCP ([googleapis#2619](googleapis#2619)) ([f6678f8](googleapis@f6678f8)) * **auth:** Add Protected Resource Metadata endpoint ([googleapis#2698](googleapis#2698)) ([b53dcf2](googleapis@b53dcf2)) * **auth:** Support manual PRM override ([googleapis#2717](googleapis#2717)) ([283e4e3](googleapis@283e4e3)) * **dataplex:** Add support for lookup context tool. ([googleapis#2744](googleapis#2744)) ([facb69d](googleapis@facb69d)) * Remove deprecations and update tools-file flag ([googleapis#2806](googleapis#2806)) ([ab64c95](googleapis@ab64c95)) ### Bug Fixes * **ci:** Remove search index generation from preview deployment workflow ([googleapis#2859](googleapis#2859)) ([f8891b8](googleapis@f8891b8)) * **docs:** Skip empty folders in pagination & reduce PR comment noise ([googleapis#2853](googleapis#2853)) ([9ebd93a](googleapis@9ebd93a)) * **http:** Sanitize non-2xx error output ([googleapis#2654](googleapis#2654)) ([5bef954](googleapis@5bef954)) * **skills:** Fix integer parameter parsing through agent skills ([googleapis#2847](googleapis#2847)) ([4564efe](googleapis@4564efe)) ### Documentation * Release upgraded docsite ([googleapis#2831](googleapis#2831)) ([5b25ce0](googleapis@5b25ce0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> c6b811c

duwenxin99 requested a review from a team as a code owner March 3, 2026 18:22

blunderbuss-gcf bot assigned Yuan325 Mar 3, 2026

gemini-code-assist bot reviewed Mar 3, 2026

View reviewed changes

internal/auth/generic/generic.go Show resolved Hide resolved

duwenxin99 changed the title ~~feat(auth): add generic authServices~~ feat(auth): add generic authService type Mar 4, 2026

duwenxin99 force-pushed the mcp-as branch from 7e3ac07 to 95c34ee Compare March 4, 2026 17:54

duwenxin99 assigned averikitsch and unassigned Yuan325 Mar 4, 2026

averikitsch reviewed Mar 6, 2026

View reviewed changes