test(source/http): create MCP integration tests#2842
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the HTTP tool integration tests to leverage a native MCP JSON-RPC protocol for interacting with tools. This change simplifies the testing framework by abstracting the underlying communication mechanism into a dedicated helper, making tests more consistent and easier to maintain. As a result of this refactoring, the continuous integration configuration has been substantially reduced, removing many specific test steps and secret definitions that are no longer relevant to the streamlined HTTP test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the HTTP integration tests to utilize native MCP JSON-RPC protocol invocation helpers, improving the testing methodology for HTTP tools. However, a critical issue has been identified where the changes inadvertently remove almost all other integration tests from the CI pipeline, which could severely impact test coverage and needs to be addressed. Additionally, there's an opportunity to improve code maintainability by extracting duplicated error handling logic within the HTTP integration tests into a shared helper function.
8b9a9f8 to
77e10c4
Compare
71cca69 to
aaa8b2f
Compare
77e10c4 to
9816437
Compare
aaa8b2f to
d120d35
Compare
9816437 to
e4512a1
Compare
d06488f to
6f37050
Compare
3633430 to
082e280
Compare
4ca8fb9 to
b428321
Compare
b48c731 to
e0686e3
Compare
b8680be to
78ea17e
Compare
bc7fa2f to
7fe2c51
Compare
1633f13 to
c1dc605
Compare
7fe2c51 to
37f4fdb
Compare
c1dc605 to
004eb32
Compare
4349247 to
49352dc
Compare
815da44 to
f2c1e86
Compare
49352dc to
009f45b
Compare
5749645 to
cd6e882
Compare
b934ec8 to
5364cf1
Compare
cd6e882 to
e51567b
Compare
5364cf1 to
4b41e0d
Compare
e51567b to
733c4a2
Compare
733c4a2 to
133303a
Compare
bf0e81e to
b9e27e0
Compare
Yuan325
left a comment
There was a problem hiding this comment.
Awesome, thank you!! LGTM :)
b9e27e0 to
8aaa73e
Compare
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
) ## Overview This PR adds the mapped integration tests for HTTP tools using the new native MCP harness. ## Changes - Created `tests/http/http_mcp_test.go` and ported all relevant tests from the legacy `http_integration_test.go` to use the `/mcp` pathway. - Includes covered positive paths, negative paths, and optional query parameter variations. ## Checklist - [x] Ensure the tests and linter pass 0857c29
Overview
This PR adds the mapped integration tests for HTTP tools using the new native MCP harness.
Changes
tests/http/http_mcp_test.goand ported all relevant tests from the legacyhttp_integration_test.goto use the/mcppathway.Checklist