Skip to content

test(couchbase): refactor integration tests to use testcontainers#2858

Merged
duwenxin99 merged 13 commits intomainfrom
couchbase
Mar 26, 2026
Merged

test(couchbase): refactor integration tests to use testcontainers#2858
duwenxin99 merged 13 commits intomainfrom
couchbase

Conversation

@duwenxin99
Copy link
Copy Markdown
Contributor

Refactor Couchbase integration tests to use testcontainers to fix test flakiness.
🛠️ Fixes #2808

@duwenxin99 duwenxin99 requested a review from a team as a code owner March 26, 2026 18:44
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Couchbase integration tests to use Testcontainers for dynamic environment setup, replacing the previous reliance on environment variables. The changes include managing the container lifecycle within the test, updating configuration helpers, and organizing test cases into subtests. Feedback was provided regarding a regression in error reporting where the command output is no longer logged if the toolbox fails to start, which hinders diagnostic capabilities.

@Yuan325 Yuan325 added the release candidate Use label to signal PR should be included in the next release. label Mar 26, 2026
@duwenxin99 duwenxin99 enabled auto-merge (squash) March 26, 2026 21:36
@duwenxin99 duwenxin99 merged commit 941c752 into main Mar 26, 2026
19 checks passed
@duwenxin99 duwenxin99 deleted the couchbase branch March 26, 2026 23:22
@github-actions
Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-2858 have been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release candidate Use label to signal PR should be included in the next release.

Projects

None yet

2 participants