test(spannersql): add semantic search integration tests and docs#2889
test(spannersql): add semantic search integration tests and docs#2889duwenxin99 merged 9 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for Spanner semantic search by adding logic to create a temporary vector table and configure the semantic search tool. Feedback was provided to enhance the test's realism and performance by creating a vector index on the embedding column and utilizing the ANN_SEARCH function for more idiomatic query execution.
duwenxin99
changed the title
|
🚀 Cloudflare Preview Ready! 🔎 View Preview: https://pr-2889.toolbox-docs-6xc.pages.dev (Note: Subsequent pushes to this PR will automatically update the preview at this same URL) |
duwenxin99
changed the title
duwenxin99
changed the title
duwenxin99
changed the title
TanmayVartak
left a comment
TanmayVartak
left a comment
There was a problem hiding this comment.
There are unrelated formatting changes. Spanner related code LGTM
duwenxin99
added
the
release candidate
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Test failure is being swalllowed
=== RUN TestSpannerPostgresqlToolEndpoints
| spanner_integration_test.go:1042: Creating temporary PostgreSQL database: pg_db_e170263554ee421487988fac67034420
| spanner_integration_test.go:1045: unable to create PostgreSQL database: rpc error: code = InvalidArgument desc = Invalid create statement. Database ids should be 2-30 characters long, contain only lowercase letters, numbers, underscores or hyphens, start with a letter and cannot end with an underscore or hyphen. Example of valid create statement: CREATE DATABASE "my-database"
| error details: name = Help desc = The rules of Cloud Spanner database IDs. url = https://cloud.google.com/spanner/docs/data-definition-language#database-id-names
| --- FAIL: TestSpannerPostgresqlToolEndpoints (0.06s)
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
4 participants
Part of #2415