Skip to content

chore(deps): update JS sample deps#2969

Open
twishabansal wants to merge 5 commits intomainfrom
update-deps
Open

chore(deps): update JS sample deps#2969
twishabansal wants to merge 5 commits intomainfrom
update-deps

Conversation

@twishabansal
Copy link
Copy Markdown
Contributor

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @toolbox-sdk/core dependency from version ^0.3.0 to ^1.0.0 across several documentation samples, including LangChain, GenAI, Genkit, and LlamaIndex. The review feedback identifies a violation of the repository style guide regarding the PR description format and highlights necessary version updates for zod and @langchain/core to resolve peer dependency mismatches introduced by the SDK upgrade.

"@langchain/google-genai": "^2.1.19",
"@langchain/google-vertexai": "^2.1.19",
"@toolbox-sdk/core": "^0.3.0",
"@toolbox-sdk/core": "^1.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating @toolbox-sdk/core to ^1.0.0 introduces a peer dependency requirement for zod: ^3.24.4. The current version of zod declared in this file is ^3.23.8 (line 16). It is recommended to update zod to at least ^3.24.4 to ensure compatibility and avoid peer dependency warnings during installation.

"@langchain/google-genai": "^2.1.19",
"@langchain/langgraph": "^1.0.0",
"@toolbox-sdk/core": "^0.3.0",
"@toolbox-sdk/core": "^1.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating @toolbox-sdk/core to ^1.0.0 is correct. However, I noticed that @langchain/core is currently at ^1.1.26 (line 14), which is lower than the ^1.1.27 required by @langchain/google-genai's peer dependencies (as seen in the lockfile). It is recommended to update @langchain/core to at least ^1.1.27 to ensure compatibility across all dependencies.

@twishabansal twishabansal marked this pull request as ready for review April 7, 2026 07:35
@twishabansal twishabansal requested a review from a team as a code owner April 7, 2026 07:35
@twishabansal
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @toolbox-sdk/core dependency from version ^0.3.0 to ^1.0.0 across several JavaScript documentation samples. The review feedback correctly identifies this as a major version update and requests that the PR title be updated with a ! to signify a breaking change, as required by the repository's style guide for proper release automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants