Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the @toolbox-sdk/core dependency from version ^0.3.0 to ^1.0.0 across several documentation samples, including LangChain, GenAI, Genkit, and LlamaIndex. The review feedback identifies a violation of the repository style guide regarding the PR description format and highlights necessary version updates for zod and @langchain/core to resolve peer dependency mismatches introduced by the SDK upgrade.
docs/en/documentation/configuration/pre-post-processing/js/langchain/package-lock.json
Show resolved
Hide resolved
| "@langchain/google-genai": "^2.1.19", | ||
| "@langchain/google-vertexai": "^2.1.19", | ||
| "@toolbox-sdk/core": "^0.3.0", | ||
| "@toolbox-sdk/core": "^1.0.0", |
There was a problem hiding this comment.
| "@langchain/google-genai": "^2.1.19", | ||
| "@langchain/langgraph": "^1.0.0", | ||
| "@toolbox-sdk/core": "^0.3.0", | ||
| "@toolbox-sdk/core": "^1.0.0", |
There was a problem hiding this comment.
Updating @toolbox-sdk/core to ^1.0.0 is correct. However, I noticed that @langchain/core is currently at ^1.1.26 (line 14), which is lower than the ^1.1.27 required by @langchain/google-genai's peer dependencies (as seen in the lockfile). It is recommended to update @langchain/core to at least ^1.1.27 to ensure compatibility across all dependencies.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the @toolbox-sdk/core dependency from version ^0.3.0 to ^1.0.0 across several JavaScript documentation samples. The review feedback correctly identifies this as a major version update and requests that the PR title be updated with a ! to signify a breaking change, as required by the repository's style guide for proper release automation.
Description
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>