test(BigQuery): Add MCP Integration tests#2987
Draft
dishaprakash wants to merge 8 commits intomcp-cloud-sql-admin-api-testsfrom
Draft
test(BigQuery): Add MCP Integration tests#2987dishaprakash wants to merge 8 commits intomcp-cloud-sql-admin-api-testsfrom
dishaprakash wants to merge 8 commits intomcp-cloud-sql-admin-api-testsfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a common testing framework for BigQuery tools to reduce code duplication across integration and MCP tests. It refactors existing integration tests and adds a new suite for MCP tool endpoints. Feedback includes suggestions to refactor duplicated MCP invocation logic to align with repository rules on efficient body unmarshaling, enhance the robustness of data type test assertions, and remove unused dead code in the new test file.
934a1ab to
a6dbd2a
Compare
54da7cf to
735f4e7
Compare
f495be1 to
7110764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replicated all existing bigquery integation tests with mcp endpoints