refactor(tests): move helpers from legacy tests to MCP test files for AlloyDB and HTTP#2991
Open
anubhav756 wants to merge 1 commit intoanubhav-mcp-alloydbainlfrom
Open
refactor(tests): move helpers from legacy tests to MCP test files for AlloyDB and HTTP#2991anubhav756 wants to merge 1 commit intoanubhav-mcp-alloydbainlfrom
anubhav756 wants to merge 1 commit intoanubhav-mcp-alloydbainlfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the HTTP integration tests by centralizing test server handlers and configuration logic into tests/http/http_mcp_test.go. The changes remove redundant code from tests/http/http_integration_test.go and clean up imports across multiple test files. I have provided feedback regarding the use of GET requests for operations that process request bodies, which violates REST standards, and suggested improvements for robust error handling in the mock handlers.
anubhav756
force-pushed
the
anubhav-refactor
branch
from
ceb1cd7 to
11a3aec
Compare
anubhav756
force-pushed
the
anubhav-mcp-alloydbainl
branch
from
e284d4f to
2df66d2
Compare
anubhav756
force-pushed
the
anubhav-refactor
branch
from
11a3aec to
7e4f972
Compare
anubhav756
force-pushed
the
anubhav-mcp-alloydbainl
branch
from
2df66d2 to
3ebac40
Compare
anubhav756
force-pushed
the
anubhav-refactor
branch
2 times, most recently
from
a8b0611 to
af509ce
Compare
anubhav756
force-pushed
the
anubhav-mcp-alloydbainl
branch
2 times, most recently
from
207bdc3 to
ec26c46
Compare
… AlloyDB and HTTP This PR relocates helper functions, mock servers, and test setup configurations from the legacy integration test files (`alloydb_integration_test.go`, `http_integration_test.go`) to their corresponding new MCP test files (`alloydb_mcp_test.go`, `http_mcp_test.go`). This aligns with the project's transition strategy to ensure that the new MCP tests are self-contained and do not depend on legacy files or harnesses that are slated for eventual deletion.
anubhav756
force-pushed
the
anubhav-refactor
branch
from
af509ce to
d0b2e84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relocates helper functions, mock servers, and test setup configurations from the legacy integration test files (
alloydb_integration_test.go,http_integration_test.go) to their corresponding new MCP test files (alloydb_mcp_test.go,http_mcp_test.go). This aligns with the project's transition strategy to ensure that the new MCP tests are self-contained and do not depend on legacy files or harnesses that are slated for eventual deletion.