Conversation
Reverted one occurrence of "genai-toolbox" which should *not* be updated to "mcp-toolbox" since it's in the explanation of why we had the old name.
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to correct a historical repository URL reference. Feedback was provided to improve the phrasing for conciseness and to use full HTTPS URLs for better link resolution. Additionally, the reviewer pointed out that the PR title and description must be updated to comply with the repository's style guide regarding Conventional Commits and issue references.
|
|
||
| > [!NOTE] | ||
| > This solution was originally named “Gen AI Toolbox for Databases” (github.com/googleapis/mcp-toolbox) as its initial development predated MCP, but was renamed to align with the MCP compatibility. | ||
| > This solution was originally named “Gen AI Toolbox for Databases” (github.com/googleapis/genai-toolbox) as its initial development predated MCP, but was renamed to align with the MCP compatibility. |
There was a problem hiding this comment.
The phrasing 'align with the MCP compatibility' is redundant; 'align with MCP' or 'for MCP compatibility' is more concise. Additionally, using the full URL with the https:// protocol ensures better link resolution across different markdown renderers.
Also, the PR title Update README.md does not follow the Conventional Commits format required by the repository style guide (e.g., docs: update historical repository URL in README). Please also update the issue reference placeholder Fixes #<issue_number_goes_here> in the PR description.
| > This solution was originally named “Gen AI Toolbox for Databases” (github.com/googleapis/genai-toolbox) as its initial development predated MCP, but was renamed to align with the MCP compatibility. | |
| > This solution was originally named "Gen AI Toolbox for Databases" (https://github.com/googleapis/genai-toolbox) as its initial development predated MCP, but was renamed for MCP compatibility. |
References
- PR titles must follow the Conventional Commits format:
<type>[optional scope]: <description>. (link)
Reverted one occurrence of "genai-toolbox" which should not be updated to "mcp-toolbox" since it's in the explanation of why we had the old name.
Description
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>