Skip to content

feat(mcp): add Secure Parameters support for mcp v2026-06#3394

Open
duwenxin99 wants to merge 6 commits into
mcp-v202606from
feat/secure-param-draft-mcp
Open

feat(mcp): add Secure Parameters support for mcp v2026-06#3394
duwenxin99 wants to merge 6 commits into
mcp-v202606from
feat/secure-param-draft-mcp

Conversation

@duwenxin99

Copy link
Copy Markdown
Contributor

No description provided.

@duwenxin99 duwenxin99 requested a review from a team as a code owner June 10, 2026 22:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for secure parameters in the Model Context Protocol (MCP) server. It updates tool manifest generation to separate standard and secure parameters, filters out tools with secure parameters if the client does not support them, and validates and merges standard and secure arguments during tool execution. The review feedback highlights an issue where authentication parameters for secure parameters are discarded instead of being merged, suggests defensive nil checks to prevent potential nil pointer dereferences when accessing parameters, and recommends returning INVALID_PARAMS instead of METHOD_NOT_FOUND when a client lacks the secure-params capability to comply with the JSON-RPC specification.

Comment thread internal/server/mcp/vdraft/manifests.go
Comment thread internal/server/mcp/vdraft/manifests.go
Comment thread internal/server/mcp/vdraft/manifests.go
Comment thread internal/server/mcp/vdraft/method.go Outdated
Comment thread internal/server/mcp/vdraft/method.go Outdated
@duwenxin99 duwenxin99 changed the title feat(mcp): add secure param parsing for mcp v2026-06 feat(mcp): add Secure Parameters support for mcp v2026-06 Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants