ci: fix integration test skips and centralize core pattern#3401
Open
anubhav756 wants to merge 1 commit into
Open
ci: fix integration test skips and centralize core pattern#3401anubhav756 wants to merge 1 commit into
anubhav756 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the file-change detection patterns across all 47 test shards in .ci/integration.cloudbuild.yaml to include additional core directories and files. The review feedback correctly points out a significant amount of duplication introduced by this change and suggests a maintainable, DRY alternative: writing the shared core pattern to a file in an initial step and reading it dynamically in each shard.
0f1cf98 to
d2aa6da
Compare
d2aa6da to
0ae995b
Compare
averikitsch
approved these changes
Jun 11, 2026
0d817cb to
2a4f573
Compare
2a4f573 to
13bf2ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the integration tests on Cloud Build suffer from regex evaluation and maintainability issues within
.ci/integration.cloudbuild.yaml:internal/util/parameters/parameters.goin fix: escape delimiter characters in applyEscape to prevent SQL injection #2811) skip many integration test shards because theirPATTERNonly looked for specific database source paths.mysqlandmssqlused unanchored substring matching (mysql|), which accidentally triggered them whenever their Cloud SQL counterparts (cloudsqlmysql,cloudsqlmssql) were edited, leading to redundant/incorrect test runs.Changes
.ci/core_pattern.txtfile that contains core path regex (coveringinternal/server/,internal/util/,internal/auth/, etc.).$$(cat .ci/core_pattern.txt), cleaning up the YAML file.(^|/)to all integration-specific regex terms (e.g.,mysqlis now(^|/)mysql/).postgres/changes correctly triggeringalloydb,alloydb-pg, andcloud-sql-pgshards).Checklist
!if this involves a breaking change