fix(datalineage): increase integration test connection timeout#3411
fix(datalineage): increase integration test connection timeout#3411duwenxin99 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the polling timeouts in the data lineage integration tests from 90 seconds to 3 minutes to account for eventual consistency. The reviewer points out that having multiple 3-minute timeouts could cause the total test execution to exceed the overall 5-minute context timeout, potentially causing test flakiness. They recommend increasing the overall test timeout to 10 minutes to prevent this issue.
| // Poll up to 90 seconds for eventual consistency | ||
| links, err := pollSearchLineage(t, "my-datalineage-search-tool", reqBody, sourceFQN, targetFQN, 90*time.Second) | ||
| // Poll up to 3 minutes for eventual consistency | ||
| links, err := pollSearchLineage(t, "my-datalineage-search-tool", reqBody, sourceFQN, targetFQN, 3*time.Minute) |
There was a problem hiding this comment.
Increasing the polling timeout to 3 minutes here (and another 3 minutes in runDatalineageSearchWithProcessDetailsTest) means the total potential test execution time can exceed the overall test context timeout of 5 minutes (defined at line 167). Specifically, the test performs server startup wait (up to 3 minutes), first lineage poll (up to 3 minutes), and process details poll (up to 3 minutes). If these steps take longer than 5 minutes in total, the overall context ctx will be cancelled, killing the server command and causing subsequent requests to fail. Please consider increasing the overall test timeout at line 167 (e.g., to 10 minutes) to prevent test flakiness.
2 participants
fix #3386