feat(server/mcp): support com.google.cloud/toolbox.v1 extension in v20260728 - #3801
Open
duwenxin99 wants to merge 6 commits into
Open
feat(server/mcp): support com.google.cloud/toolbox.v1 extension in v20260728#3801duwenxin99 wants to merge 6 commits into
duwenxin99 wants to merge 6 commits into
Conversation
duwenxin99
force-pushed
the
feat/add-toolbox-v1-extension
branch
from
August 10, 2026 21:44
4475056 to
63c5c21
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the MCP server implementation to return tool execution errors (such as invalid parameters or URL binding conflicts) as successful JSON-RPC responses with IsError: true and the error details in the content, rather than returning JSON-RPC protocol-level errors. It also refactors PopulateUrlParams to return an error when a client attempts to provide a parameter that is bound by the URL, and switches to using util.DecodeJSON for array and map parameter parsing. Additionally, the default supported extension com.google.cloud/toolbox.v1 is registered and verified in the 2026-07-28 protocol version. I have no feedback to provide as there are no review comments.
duwenxin99
force-pushed
the
feat/add-toolbox-v1-extension
branch
from
August 10, 2026 22:27
3fdab63 to
b204a5a
Compare
averikitsch
reviewed
Aug 11, 2026
averikitsch
approved these changes
Aug 11, 2026
averikitsch
reviewed
Aug 11, 2026
duwenxin99
enabled auto-merge (squash)
August 12, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add server support for the Toolbox experimental extension.