Skip to content

feat(server/mcp): support com.google.cloud/toolbox.v1 extension in v20260728 - #3801

Open
duwenxin99 wants to merge 6 commits into
mainfrom
feat/add-toolbox-v1-extension
Open

feat(server/mcp): support com.google.cloud/toolbox.v1 extension in v20260728#3801
duwenxin99 wants to merge 6 commits into
mainfrom
feat/add-toolbox-v1-extension

Conversation

@duwenxin99

@duwenxin99 duwenxin99 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Add server support for the Toolbox experimental extension.

@duwenxin99
duwenxin99 requested review from a team as code owners August 10, 2026 21:43
@duwenxin99
duwenxin99 force-pushed the feat/add-toolbox-v1-extension branch from 4475056 to 63c5c21 Compare August 10, 2026 21:44

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MCP server implementation to return tool execution errors (such as invalid parameters or URL binding conflicts) as successful JSON-RPC responses with IsError: true and the error details in the content, rather than returning JSON-RPC protocol-level errors. It also refactors PopulateUrlParams to return an error when a client attempts to provide a parameter that is bound by the URL, and switches to using util.DecodeJSON for array and map parameter parsing. Additionally, the default supported extension com.google.cloud/toolbox.v1 is registered and verified in the 2026-07-28 protocol version. I have no feedback to provide as there are no review comments.

@duwenxin99
duwenxin99 force-pushed the feat/add-toolbox-v1-extension branch from 3fdab63 to b204a5a Compare August 10, 2026 22:27
@duwenxin99 duwenxin99 added the release candidate Use label to signal PR should be included in the next release. label Aug 10, 2026
Comment thread docs/en/reference/cli.md Outdated
Comment thread internal/server/mcp/v20260728/extensions_test.go
@duwenxin99
duwenxin99 enabled auto-merge (squash) August 12, 2026 17:48
@duwenxin99 duwenxin99 removed the release candidate Use label to signal PR should be included in the next release. label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants