Skip to content

feat: Allow setting ingress_control_config when creating a SandboxEnvironmentTemplate via the SDK (Python, Java, JS). #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+43 −30
Open

feat: Allow setting ingress_control_config when creating a SandboxEnvironmentTemplate via the SDK (Python, Java, JS). #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/converters/_sandboxtemplates_converters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ export function createSandboxEnvironmentTemplateConfigToVertex(
);
}

const fromIngressControlConfig = common.getValueByPath(fromObject, [
'ingressControlConfig',
]);
if (parentObject !== undefined && fromIngressControlConfig != null) {
common.setValueByPath(
parentObject,
['ingressControlConfig'],
fromIngressControlConfig,
);
}

return toObject;
}

Expand Down
62 changes: 32 additions & 30 deletions src/types/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,36 +2639,6 @@ export declare interface SandboxEnvironmentTemplateEgressControlConfig {
networkAttachment?: string;
}

/** Config for creating a Sandbox Template. */
export declare interface CreateSandboxEnvironmentTemplateConfig {
/** Used to override HTTP request options. */
httpOptions?: genaiTypes.HttpOptions;
/** Abort signal which can be used to cancel the request.

NOTE: AbortSignal is a client-only operation. Using it to cancel an
operation will not cancel the request in the service. You will still
be charged usage for any applicable operations.
*/
abortSignal?: AbortSignal;
/** The custom container environment for the sandbox template. */
customContainerEnvironment?: SandboxEnvironmentTemplateCustomContainerEnvironment;
/** The default container environment for the sandbox template. */
defaultContainerEnvironment?: SandboxEnvironmentTemplateDefaultContainerEnvironment;
/** The egress control config for the sandbox template. */
egressControlConfig?: SandboxEnvironmentTemplateEgressControlConfig;
/** Waits for the operation to complete before returning. */
waitForCompletion?: boolean;
}

/** Parameters for creating Sandbox Environment Templates. */
export declare interface CreateSandboxEnvironmentTemplateRequestParameters {
/** Name of the agent engine to create the template under. */
name: string;
/** The display name of the sandbox template. */
displayName: string;
config?: CreateSandboxEnvironmentTemplateConfig;
}

/** PSC config that is used to automatically create PSC endpoints in the user projects. */
export declare interface PSCAutomationConfig {
/** Output only. Error message if the PSC service automation failed. */
Expand Down Expand Up @@ -2699,6 +2669,38 @@ export declare interface PrivateServiceConnectConfig {
serviceAttachment?: string;
}

/** Config for creating a Sandbox Template. */
export declare interface CreateSandboxEnvironmentTemplateConfig {
/** Used to override HTTP request options. */
httpOptions?: genaiTypes.HttpOptions;
/** Abort signal which can be used to cancel the request.

NOTE: AbortSignal is a client-only operation. Using it to cancel an
operation will not cancel the request in the service. You will still
be charged usage for any applicable operations.
*/
abortSignal?: AbortSignal;
/** The custom container environment for the sandbox template. */
customContainerEnvironment?: SandboxEnvironmentTemplateCustomContainerEnvironment;
/** The default container environment for the sandbox template. */
defaultContainerEnvironment?: SandboxEnvironmentTemplateDefaultContainerEnvironment;
/** The egress control config for the sandbox template. */
egressControlConfig?: SandboxEnvironmentTemplateEgressControlConfig;
/** Waits for the operation to complete before returning. */
waitForCompletion?: boolean;
/** The ingress control config for the sandbox template. */
ingressControlConfig?: PrivateServiceConnectConfig;
}

/** Parameters for creating Sandbox Environment Templates. */
export declare interface CreateSandboxEnvironmentTemplateRequestParameters {
/** Name of the agent engine to create the template under. */
name: string;
/** The display name of the sandbox template. */
displayName: string;
config?: CreateSandboxEnvironmentTemplateConfig;
}

/** A sandbox environment template. */
export declare interface SandboxEnvironmentTemplate {
/** Output only. The timestamp when this SandboxEnvironmentTemplate was created. */
Expand Down
Loading