fix: deeprecation warning about _UnionGenericAlias'#2225
Open
FomalhautWeisszwerg wants to merge 4 commits intogoogleapis:mainfrom
Open
fix: deeprecation warning about _UnionGenericAlias'#2225FomalhautWeisszwerg wants to merge 4 commits intogoogleapis:mainfrom
_UnionGenericAlias'#2225FomalhautWeisszwerg wants to merge 4 commits intogoogleapis:mainfrom
Conversation
…ed for removal in Python 3.17`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @FomalhautWeisszwerg, Thanks for reaching out us! I can see that few checks were failed for the above PR, could you please check once. Thanks |
…both `Union[T1, T2]` and `T1 | T2`.
Author
|
@Venkaiahbabuneelam Thanks for reviewing. To fix it, I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About This Pull Request
Type
fix
Summary
When using google-genai on Python 3.14, following warning is raised
This PR fixes the warning reported #1640 and improves future compatibility.
Detail
Currently, google-genai uses the CPython's private object
typing._UnionGenericAlias. Howevertyping._UnionGenericAliasis deprecated and planned to remove until Python 3.17. And google-genai required Python >= 3.10 so the fallback branch forPython <= 3.10no longer needed.The changes are
typing._UnionGenericAliasimportingPython <= 3.10I hope that I could be of some help, even if only a little.
Thanks for reviewing.