-
Notifications
You must be signed in to change notification settings - Fork 490
feat: add additional-paths property to manifest releaser #2336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before, packagePaths was an array of strings, i.e. the name of each package. Now, packagePaths is a Record<string, string[]>, with the key being the name of each package, and the value being an aray of additionalPaths for that package.
|
Hi @chingor13, sorry for the nudge - are you still maintaining this project? |
chingor13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and sorry for the delay in reviewing.
This mostly looks fine although we should explicitly define what the expected logic is if an additional path coincides with a different component's path or additional paths. Currently, we sort by the components' path length with the longest first as a way to prefer the deepest path in the case of overlapping paths. With this new logic, we are still sorting based on the main path, and preferring its additional paths over any other ones.
Instead, we may need to invert the mapping and have the keys be all the "paths" (main & additional) and the value is the main component path to associate to.
|
Hi @jack-lewin will you have time to update your PR or do you need help ? Thank you for this PR |
|
sync with the latest main: jack-lewin#1 |
|
We could use this feature in our very large monorepo. Any plans to merge this ? |
|
Any plans to merge this feature? |
|
The absence of this feature is also blocking us from adopting release-please in our repo. |
|
I've been searching for the ability to have multiple components share a common directory such that any updates to common code would trigger a PR request to all associated components. Looks like this change is exactly what is needed. @chingor13 any hope of getting this in anytime soon? |
|
please merge this. we really need it. the main reason most people use a monorepo is to share dependencies between packages |
|
I pulled main and implemented a fix for @chingor13's suggestion here: #2534 |
|
Thank you @stan-stately for picking this up! @chingor13, we'd really appreciate a review on #2534 - I think it makes sense to focus on that branch since it's more up-to-date & addresses your previous suggestion. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1921 🦕
This PR adds an
additional-pathsproperty to the manifest releaser.Additional paths are useful for monorepos where a package might depend files from other directories.
For example, if we want to trigger a release in
apps/my-app-2when commits are found inlibs/my-lib:{ "packages": { "apps/my-app-1": {}, "apps/my-app-2": { "additional-paths": ["libs/my-lib"] // additional-paths would be a new config option } } }Best reviewed commit-by-commit.