fix: workspace - always update manifest versions #2505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2172 🦕
For the NodeWorkspace and CargoWorkspace plugin, manifest updates are generated with an empty versionMap.
From what I understand, the buildUpdatedVersions method is only adding candidates in the
updatedPathVersions
return (but is correctly adding everything in theupdatedVersions
return).This feels like an oversight, as I don't know why the
updatedVersions
and theupdatedPathVersions
could have different versions.I managed to make tests fail with my first commit, where manifest updates are not generated for cargo and node in the current version. (I also added the assertions for the maven plugin, but it works correctly).
The second commit introduce my proposition to fix this: always adding new versions to both outputs of the buildUpdatedVersions method.
What do you think about this change ?
Could this modification have side effects that I am not aware of ?