Skip to content

fix: workspace - always update manifest versions #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raphael-trzpit
Copy link

@raphael-trzpit raphael-trzpit commented Mar 12, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2172 🦕

For the NodeWorkspace and CargoWorkspace plugin, manifest updates are generated with an empty versionMap.

From what I understand, the buildUpdatedVersions method is only adding candidates in the updatedPathVersions return (but is correctly adding everything in the updatedVersions return).
This feels like an oversight, as I don't know why the updatedVersions and the updatedPathVersions could have different versions.

I managed to make tests fail with my first commit, where manifest updates are not generated for cargo and node in the current version. (I also added the assertions for the maven plugin, but it works correctly).

The second commit introduce my proposition to fix this: always adding new versions to both outputs of the buildUpdatedVersions method.

What do you think about this change ?
Could this modification have side effects that I am not aware of ?

@raphael-trzpit raphael-trzpit requested review from a team as code owners March 12, 2025 13:56
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 12, 2025
@raphael-trzpit
Copy link
Author

Hi @chingor13 , I hope you're doing well! I just wanted to ping you for a review when you have a moment. Let me know if you need any changes or more context.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not updating .release-please-manifest.json
2 participants