Skip to content

[klippa] subset CBLC/CBDT tables #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025
Merged

[klippa] subset CBLC/CBDT tables #1351

merged 4 commits into from
Feb 19, 2025

Conversation

qxliu76
Copy link
Contributor

@qxliu76 qxliu76 commented Feb 11, 2025

Also updated SubsetTable trait.
Harfbuzz implementation is suboptimal, rust code is using a different approach, following fonttools' method:
https://github.com/fonttools/fonttools/blob/7854669acd63be43e1ad41d0486297d8d6da325d/Lib/fontTools/subset/__init__.py#L1799

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes inline but nothing major is jumping out at me...

@qxliu76 qxliu76 merged commit 174304d into main Feb 19, 2025
10 checks passed
@qxliu76 qxliu76 deleted the subset_cblc branch February 19, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants