[skrifa] tthint: adjust DELTAP/DELTAC limits #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We limited these to point count/cvt size respectively but there are fonts (Arial is one) where these limits are not sufficient. Notably, you can have one exception per point/entry _and_ ppem so we can't use these counts for hard limits. Instead limit both to `(stack_size / 2)` since each iteration requires two elements from the stack.
drott
added a commit
to drott/fontations
that referenced
this pull request
Feb 24, 2025
Release tip of tree with fix for googlefonts#1363 hang in gsub processing during autohinting of Noto Nastaliq. Changes for read-fonts from read-fonts-v0.27.1 to 0.27.1 5657ab8 [chore] Clippy day 53407d0 [read-fonts] CFF charsets (googlefonts#1361) Changes for write-fonts from write-fonts-v0.36.0 to 0.36.0 5657ab8 [chore] Clippy day 029f62f [font_builder] provide more expository comment 7f95b52 [font_builder] test recommended table order a49be74 [font_builder] test checksum_adjustment ffc69ee [font_builder] compute head.checksum_adjustment and sort table in recommended order 53407d0 [read-fonts] CFF charsets (googlefonts#1361) Changes for skrifa from skrifa-v0.28.0 to 0.28.0 e250138 [skrifa] autohint: use visited set when processing GSUB lookups (googlefonts#1365) 441a388 [skrifa] Remove unused write-fonts dev-dep 652b3ca Apply limits to cmap12 iterator (googlefonts#1352) 24fb1c8 [skrifa] tthint: adjust DELTAP/DELTAC limits (googlefonts#1353)
drott
added a commit
that referenced
this pull request
Feb 24, 2025
Release tip of tree with fix for #1363 hang in gsub processing during autohinting of Noto Nastaliq. Changes for read-fonts from read-fonts-v0.27.1 to 0.27.1 5657ab8 [chore] Clippy day 53407d0 [read-fonts] CFF charsets (#1361) Changes for write-fonts from write-fonts-v0.36.0 to 0.36.0 5657ab8 [chore] Clippy day 029f62f [font_builder] provide more expository comment 7f95b52 [font_builder] test recommended table order a49be74 [font_builder] test checksum_adjustment ffc69ee [font_builder] compute head.checksum_adjustment and sort table in recommended order 53407d0 [read-fonts] CFF charsets (#1361) Changes for skrifa from skrifa-v0.28.0 to 0.28.0 e250138 [skrifa] autohint: use visited set when processing GSUB lookups (#1365) 441a388 [skrifa] Remove unused write-fonts dev-dep 652b3ca Apply limits to cmap12 iterator (#1352) 24fb1c8 [skrifa] tthint: adjust DELTAP/DELTAC limits (#1353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We limited these to point count/cvt size respectively but there are fonts (Arial is one) where these limits are not sufficient. Notably, you can have one exception per point/entry and ppem so we can't use these counts for hard limits.
Instead limit both to
(stack_size / 2)since each iteration requires two elements from the stack.