-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GSC to crater #9
base: main
Are you sure you want to change the base?
Conversation
"rev": "4de3a9eddffd7df57abc0f6f28c83a428329f437", | ||
"auth": true, | ||
"config_files": [ | ||
"config.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have a bit of a problem here, which is that we really expect config files to be in either a sources
or Sources
directory, but this repo uses a source
directory.
We had a similar issue with GS, where everything was in a source
directory, and there was no config.yaml
; we solved that issue by adding sources/config.yaml
and then pointing from there to the actual sources located in the source
directory.
However this repo has a config.yaml, it's just in the wrong place.
Some possible solutions:
- add support in
google-fonts-sources
for sources living in asource
directory. This wouldn't be too annoying, but it feels a little bad to do this work for a single case, when we really expect fonts to usesource
orsources
. - fix this in the GSC repo (rename
source
tosources
). This seems easy, but I'm not sure what breakage could result. - fix this in the GSC repo by adding a
sources
directory containing a symlink'dconfig.yaml
. This one scares me a bit, because... symlinks. Does anyone use windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add it and let it fail until one of the solutions has occurred? - I'll follow up with GSC about renaming source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can, although if the fix requires an update in GSC we'll have to PR this again with a rev that includes the fix.
We can make the directory path update. I reached out to @belluzj today to see what we need to do in the CI build workflow to accommodate this path change. @MariannaPaszkowska for future reference, we should begin to use |
And to clarify, we expect |
Rev is just latest from https://github.com/googlefonts/googlesans-code/commits/main/