Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSC to crater #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GSC to crater #9

wants to merge 1 commit into from

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Feb 11, 2025

"rev": "4de3a9eddffd7df57abc0f6f28c83a428329f437",
"auth": true,
"config_files": [
"config.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have a bit of a problem here, which is that we really expect config files to be in either a sources or Sources directory, but this repo uses a source directory.

We had a similar issue with GS, where everything was in a source directory, and there was no config.yaml; we solved that issue by adding sources/config.yaml and then pointing from there to the actual sources located in the source directory.

However this repo has a config.yaml, it's just in the wrong place.

Some possible solutions:

  • add support in google-fonts-sources for sources living in a source directory. This wouldn't be too annoying, but it feels a little bad to do this work for a single case, when we really expect fonts to use source or sources.
  • fix this in the GSC repo (rename source to sources). This seems easy, but I'm not sure what breakage could result.
  • fix this in the GSC repo by adding a sources directory containing a symlink'd config.yaml. This one scares me a bit, because... symlinks. Does anyone use windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add it and let it fail until one of the solutions has occurred? - I'll follow up with GSC about renaming source

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can, although if the fix requires an update in GSC we'll have to PR this again with a rev that includes the fix.

@chrissimpkins
Copy link
Member

We can make the directory path update. I reached out to @belluzj today to see what we need to do in the CI build workflow to accommodate this path change.

@MariannaPaszkowska for future reference, we should begin to use sources regularly for our source directory paths to support the crater requirements here.

@cmyr
Copy link
Member

cmyr commented Feb 11, 2025

And to clarify, we expect sources because that is what is used in the google-fonts-project-template: https://github.com/googlefonts/googlefonts-project-template/blob/main/sources/config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants