Fix encoding problem with reading .glyphspackage .glyph file - #1151
Merged
khaledhosny merged 2 commits intoJul 22, 2026
Conversation
justvanrossum
force-pushed
the
encoding-glyphspackage
branch
from
April 30, 2026 19:54
dcabafc to
cfbd53d
Compare
justvanrossum
changed the title
khaledhosny
approved these changes
Apr 30, 2026
Contributor
Author
|
Quick note about the "일" character added to the annotation test: Windows by default opens files using the cp1252 encoding. This will silently accept many utf-8 sequences. But not "일", as its utf-8 representation contains a code that is undefined in cp1252, which causes an error when decoding. While there are likey many other characters with this property, this is the one I bumped into in the Fontra bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally adjusts some test code.
This fixes a similar bug as fontra/fontra-glyphs#140. Occasional glyphsLib errors were mentioned there by @Eigi, so I went for a hunt and found one.