Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #214 #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue #214 #215

wants to merge 1 commit into from

Conversation

thlinard
Copy link

@thlinard thlinard commented Jan 8, 2025

Fix issue #214

@simoncozens
Copy link
Contributor

While this is technically correct, the non_required status is a fudge for the fact that if we do require this, very many of our fonts will stop claiming to support German.

@thlinard
Copy link
Author

thlinard commented Feb 7, 2025

While this is technically correct, the non_required status is a fudge for the fact that if we do require this, very many of our fonts will stop claiming to support German.

I think that's exactly what Dave meant when he said (#152):

Alright, I am convinced that, if a user searches for fonts that support German, and then Roboto, Poppins, Lato etc should not come up.

@simoncozens
Copy link
Contributor

It is. And as shown in that thread, there were further discussions, and the change was reverted.

@thlinard
Copy link
Author

thlinard commented Feb 7, 2025

The PR 152 was originally to move ẞ to the auxiliary character set. And indeed that change was reverted. But that left the situation where ẞ is both required and non-required.

With the current PR, "if a user searches for fonts that support German, […] Roboto, Poppins, Lato etc should not come up."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants