Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the Android Maps Testing Toolkit (
v1.1.0-rc01:com.google.android.maps.robolectric:shadows,com.google.android.maps.testing:golden, andcom.google.android.maps.testing:visual) across all 5 Android library modules (:library,:clustering,:data,:heatmaps, and:ui) to enable deterministic JVM Robolectric map shadow tests and offline golden/visual verification.Note
Kept in Draft until
com.google.android.maps.robolectric:shadows:1.1.0andcom.google.android.maps.testing:golden:1.1.0are published to Maven Central / Google Maven (currently resolved viamavenLocal()).Test Suites Added (72 New Robolectric + Maps Shadow & Golden Tests)
:library(MapsToolkitLibraryTest.kt— 32 tests):addMarker,addPolygon,addPolyline,addCircle,addGroundOverlay,addTileOverlay,buildCameraPosition,MapView.awaitMap)callbackFlowevent streams (cameraEvents,cameraMoveEvents,cameraIdleEvents,markerClickEvents,polygonClickEvents,circleClickEvents,groundOverlayClickEvents,mapClickEvents,indoorBuildingEvents)MarkerManager,PolygonManager,PolylineManager,CircleManager,GroundOverlayManagerisolation and synchronous main-thread listener registrationPolyUtil,Bounds, andPointQuadTreespatial invariants withLatLngSubject&LatLngBoundsSubject:clustering(MapsToolkitClusteringTest.kt— 12 tests):ClusterManager+DefaultClusterRendererzoom transitions (NonHierarchicalDistanceBasedAlgorithm,GridBasedAlgorithm,NonHierarchicalViewBasedAlgorithm,PreCachingAlgorithmDecorator)onClusterItemUpdatedregression tests for clearingtitle/snippettonulland updatingzIndexin-place:data(MapsToolkitDataLayerTest.kt— 12 tests):GeoJsonLayerandKmlLayerparsing, rendering, style propagation (GeoJsonPointStyletitle/snippet/draggable/flat/visible/anchor/icon,<MultiGeometry>&GeoJsonMultiLineStringCompositeStyle),Document-levelhasPlacemarks()/getGroundOverlays(),KmlLayer.removeLayerFromMap()ground overlay cleanup, and sharedMapObjectManagercoexistence:heatmaps(MapsToolkitHeatmapsTest.kt— 9 tests):HeatmapTileProviderARGB pixel verification,PixelSimilarityEnginegolden comparison,ZoomLevelSweep(z=0, 5, 10, 15, 22), upper-boundmaxX/maxYclamping, antimeridian dateline wrapping, and parameter validation:ui(MapsToolkitUiTest.kt— 7 tests):IconGenerator+BubbleDrawable+RotationLayoutbitmap dimension &PixelSimilarityEngineverification (including negative multi-turn angles) andAnimationUtil.animateMarkerToShadowLoopertrajectory verificationVerification
All 159 tests across all 6 modules pass (
BUILD SUCCESSFUL).