Conversation
… (.api dumps) - Enable kotlin explicitApi() across published modules (:library, :clustering, :data, :heatmaps, :ui) - Add explicit public visibility and return types to all public Kotlin symbols across modules - Configure Binary Compatibility Validator (BCV) for AGP 9.3 via build-logic convention plugin and root aggregate tasks - Generate and commit baseline .api dumps for :library, :clustering, :data, :heatmaps, and :ui - Add apiCheck to the CI Pull Request test workflow Fixes #1794
Contributor
Code Coverage
Files |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1794 in a stacked PR on top of #1716 (
feat/migrate-ktx-to-utils).Summary of Changes
Enable Kotlin Explicit API Mode:
kotlin { explicitApi() }inlibrary/build.gradle.kts,clustering/build.gradle.kts,data/build.gradle.kts,heatmaps/build.gradle.kts, andui/build.gradle.kts.Configure Binary Compatibility Validator (BCV):
build-logic/convention/src/main/kotlin/PublishingConventionPlugin.ktand rootbuild.gradle.ktsto support AGP 9.3 compiled release classes (bundleLibCompileToJarRelease/classes.jar).apiBuild,apiDump, andapiChecktasks per library module with R and BuildConfig exclusion filters.apiDumpandapiCheckverification tasks on root project and wiredcheckto depend onapiCheck.Baseline .api Dumps:
library/api/library.apiclustering/api/clustering.apidata/api/data.apiheatmaps/api/heatmaps.apiui/api/ui.apiCI Workflow:
apiCheckto the PR test workflow in.github/workflows/test.yml.Fixes #1794