Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googlesamples/google-signin-unity
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.1
Choose a base ref
...
head repository: googlesamples/google-signin-unity
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Nov 8, 2017

  1. Moving the local repo .aar file to .srcaar.

    This accomodates Unity adding aars regardless of being in the Editor
    directory.  The jar resolver plugin handles renaming .srcaar to .aar.
    
    Also, fixes an issue with metadata tagging files that have no labels.
    As a result, the 1.0.1 manifest has to be added to remove the old
    .aar files.
    
    Change-Id: I5e038e5731ee8ba33fcbcd34c6641d7e6ede8504
    claywilkinson committed Nov 8, 2017
    Copy the full SHA
    f9bf400 View commit details

Commits on Nov 9, 2017

  1. Copy the full SHA
    b1062be View commit details

Commits on Nov 12, 2017

  1. Removing the subclassing of UnityAppController for iOS.

    This avoids any issues when this plugin is used with  others that need
    to handle deep links, etc.
    
    Also fixes a bug when trying to sign back in after signing out.
    
    Change-Id: Ia35f228a82c4744f83fb9955bc68366c68a828a7
    claywilkinson committed Nov 12, 2017
    Copy the full SHA
    7709f87 View commit details

Commits on Nov 13, 2017

  1. Updating build,gradle to generate the support jar dependency dynamica…

    …lly.
    
    This keeps the dependency file up to date with the version of the
    plugin.
    
    Change-Id: I9bd34d73740e9be79720f1a4945fa12a8a9266fa
    claywilkinson committed Nov 13, 2017
    Copy the full SHA
    1c33763 View commit details
  2. Version 1.0.2

    Fixes iOs plugin to not extend UnityAppController
    claywilkinson committed Nov 13, 2017
    Copy the full SHA
    4b89976 View commit details
  3. Merge pull request #7 from lukezbihlyj/master

    Ensure that the AuthCode gets set correctly.
    claywilkinson authored Nov 13, 2017
    Copy the full SHA
    6c13b2c View commit details
  4. Merge pull request #7 from lukezbihlyj/master

    Ensure that the AuthCode gets set correctly.
    
    Change-Id: Icc29bf695ae993169b70c73ab027a3712fd96eb9
    claywilkinson committed Nov 13, 2017
    Copy the full SHA
    e341be4 View commit details

Commits on Nov 20, 2017

  1. Copy the full SHA
    26267ab View commit details

Commits on Dec 24, 2017

  1. Fixed a typo.

    calee88 authored and cheonganlee committed Dec 24, 2017
    Copy the full SHA
    485c208 View commit details

Commits on Jan 2, 2018

  1. Merge pull request #13 from calee88/master

    Fixed a typo.
    claywilkinson authored Jan 2, 2018
    Copy the full SHA
    0f3cc58 View commit details
  2. Copy the full SHA
    19a890d View commit details

Commits on Jan 24, 2018

  1. Prevent trying to create Uris from empty string.

    This allows the GoogleSignInPlugin to work for Games sign in.
    
    Change-Id: Id0fb740292c08542ce960ddebc8b4496b9225117
    Ingrid Fielker committed Jan 24, 2018
    Copy the full SHA
    e9c923b View commit details
  2. Bumping version number to 1.0.3

    Change-Id: I45d9c0d5723d724bdff967c4326aa9b3001d4ab0
    claywilkinson committed Jan 24, 2018
    Copy the full SHA
    13a6a53 View commit details

Commits on Feb 7, 2018

  1. Fixed a few warnings and disabled abort on lint.

    The lint error reports if your simply using an older version of a library.
    We don't want users builds to stop simply because a newer version of a
    library is available, but this is useful during our continuous builds or
    development builds, so it's now a project property.
    
    You can build the native plugin alone with: ../gradlew -PlintAbortOnError build
    Or the whole project with: ./build_all
    which will enable lintAbort automatically.
    
    Change-Id: I96f3b4c7107e200e2cc0548aee39c468d42db914
    johnb003 committed Feb 7, 2018
    Copy the full SHA
    9d6f243 View commit details
  2. Merge "Fixed a few warnings and disabled abort on lint."

    johnb003 authored and Gerrit Code Review committed Feb 7, 2018
    Copy the full SHA
    873e83b View commit details

Commits on Feb 8, 2018

  1. Copied old native files to a new structure without modification.

    Change-Id: Ib1da59d3fe61467438ea665b89457e9ad0c04985
    johnb003 committed Feb 8, 2018
    Copy the full SHA
    a2bb392 View commit details

Commits on Feb 9, 2018

  1. Merge "Copied old native files to a new structure without modification."

    johnb003 authored and Gerrit Code Review committed Feb 9, 2018
    Copy the full SHA
    c550322 View commit details

Commits on Feb 14, 2018

  1. Copied the existing iOS source files unmodified to the new native sta…

    …ging area.
    
    Change-Id: I5fe3a810f1cac8b766fd3b6a7f3abea2e3bedc7e
    johnb003 committed Feb 14, 2018
    Copy the full SHA
    1c64c30 View commit details
  2. Adding iOS Cocoapods library spec and testapp build setup.

    This also strips the Unity specific calls from the original implementation,
    but leaves the library otherwise untouched; the testapp doesn't call the
    library yet.
    
    Change-Id: Ifd69243f931e606b503a640655db46f05cdab877
    johnb003 committed Feb 14, 2018
    Copy the full SHA
    d115326 View commit details

Commits on Feb 24, 2018

  1. Updating .gitignore to not include iOS build artifacts.

    Change-Id: I8777e10ea8e4f5021aa2f606c2151797f8e2e0e4
    johnb003 committed Feb 24, 2018
    Copy the full SHA
    05edac3 View commit details
  2. Copied the java helper classes from the original native implementation.

    Change-Id: I02f8a02fc27fc8b760ddb1dda34fd1d590c1628e
    johnb003 committed Feb 24, 2018
    Copy the full SHA
    3e5bdc4 View commit details

Commits on Feb 26, 2018

  1. Adding the Android C++ library.

    Change-Id: Ia1305cee825c802859c87247ace6c986ed60ef09
    johnb003 committed Feb 26, 2018
    Copy the full SHA
    7b4a546 View commit details

Commits on Feb 27, 2018

  1. Added an Android C++ Testapp.

    Change-Id: I8b0bc628cdacb84f6a9582f064cbdaf8563c25ef
    johnb003 committed Feb 27, 2018
    Copy the full SHA
    8119ede View commit details
  2. Added a readme for the GSI C++ Library.

    Change-Id: I3a4f6b099a9de7316dd316c6f3fa89e5bd99353a
    johnb003 committed Feb 27, 2018
    Copy the full SHA
    6f72959 View commit details

Commits on Mar 16, 2018

  1. Fixing memory corruption when passing additional scopes.

    Change-Id: I3d27930e4d077ee288d1ebc892fd9a4401dc25a3
    claywilkinson committed Mar 16, 2018
    Copy the full SHA
    0e654db View commit details

Commits on Mar 21, 2018

  1. Revert "Fixing memory corruption when passing additional scopes."

    This breaks the C++ native plugin, and needs to be approved.
    
    This reverts commit 0e654db.
    
    Change-Id: Ia37d4399610ad336862163f4ad7ab6c0b3c16926
    johnb003 committed Mar 21, 2018
    Copy the full SHA
    2276051 View commit details
  2. Duplicating fix for memory corruption with extra scopes to the native…

    … plugin.
    
    Change-Id: I70cc91df221bbb5cbc0086045d00a1e9ce9bc1f3
    johnb003 committed Mar 21, 2018
    Copy the full SHA
    9faa90f View commit details

Commits on Sep 19, 2018

  1. Updating for 1.0.4

    * bumped tooling versions to latest
    * handled cancelled and other onActivityResult() return codes that
      cause NPE.
    * Depend on latest Play Services Auth library.
    
    Change-Id: Ib783e6943800d86d5a13aafd6dc86bdea601b0ab
    claywilkinson committed Sep 19, 2018
    Copy the full SHA
    588c063 View commit details
Showing with 5,930 additions and 424 deletions.
  1. +8 −0 .gitignore
  2. +1 −26 GoogleSignInPlugin/Assets/GoogleSignIn/Editor/GoogleSignInDependencies.xml
  3. +10 −0 GoogleSignInPlugin/Assets/GoogleSignIn/Editor/GoogleSignInSupportDependencies.xml.meta
  4. +27 −0 GoogleSignInPlugin/Assets/GoogleSignIn/Editor/google-signin-plugin_v1.0.1.txt
  5. +12 −0 GoogleSignInPlugin/Assets/GoogleSignIn/Editor/google-signin-plugin_v1.0.1.txt.meta
  6. +2 −1 GoogleSignInPlugin/Assets/GoogleSignIn/GoogleSignIn.cs
  7. +8 −2 GoogleSignInPlugin/Assets/GoogleSignIn/Impl/NativeFuture.cs
  8. +20 −0 GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignIn.h
  9. +35 −0 GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignIn.h.meta
  10. +345 −0 GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignIn.mm
  11. +35 −0 GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignIn.mm.meta
  12. +21 −7 GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignInAppController.h
  13. +77 −340 GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignInAppController.mm
  14. +0 −2 GoogleSignInPlugin/Assets/SignInSample.meta
  15. +6 −4 README.md
  16. +37 −3 build.gradle
  17. +5 −0 build_all.sh
  18. +1 −1 gradle/wrapper/gradle-wrapper.properties
  19. +48 −4 native-googlesignin/build.gradle
  20. +10 −14 native-googlesignin/src/main/cpp/google_signin.cc
  21. +6 −4 native-googlesignin/src/main/cpp/google_signin.h
  22. +21 −11 native-googlesignin/src/main/cpp/google_signin_bridge.cc
  23. +1 −0 native-googlesignin/src/main/cpp/google_signin_bridge.h
  24. +1 −1 native-googlesignin/src/main/cpp/google_signin_user.cc
  25. +11 −4 native-googlesignin/src/main/java/com/google/googlesignin/GoogleSignInFragment.java
  26. +4 −0 staging/DIR_README.md
  27. +40 −0 staging/native/GoogleSignInCpp.podspec
  28. +215 −0 staging/native/LICENSE
  29. +55 −0 staging/native/README.md
  30. +121 −0 staging/native/build.gradle
  31. BIN staging/native/gradle/wrapper/gradle-wrapper.jar
  32. +6 −0 staging/native/gradle/wrapper/gradle-wrapper.properties
  33. +172 −0 staging/native/gradlew
  34. +84 −0 staging/native/gradlew.bat
  35. +22 −0 staging/native/src/android/AndroidManifest.xml
  36. +51 −0 staging/native/src/android/CMakeLists.txt
  37. +398 −0 staging/native/src/android/google_signin.cc
  38. +191 −0 staging/native/src/android/google_signin_user.cc
  39. +53 −0 staging/native/src/android/google_signin_user_impl.h
  40. +547 −0 staging/native/src/android/java/com/google/googlesignin/GoogleSignInFragment.java
  41. +148 −0 staging/native/src/android/java/com/google/googlesignin/GoogleSignInHelper.java
  42. +145 −0 staging/native/src/android/java/com/google/googlesignin/TokenPendingResult.java
  43. +171 −0 staging/native/src/android/java/com/google/googlesignin/TokenRequest.java
  44. +66 −0 staging/native/src/android/java/com/google/googlesignin/TokenResult.java
  45. +153 −0 staging/native/src/android/jni.cc
  46. +71 −0 staging/native/src/android/jni_context.h
  47. +41 −0 staging/native/src/include/future.h
  48. +179 −0 staging/native/src/include/google_signin.h
  49. +46 −0 staging/native/src/include/google_signin_user.h
  50. +20 −0 staging/native/src/ios/GoogleSignIn.h
  51. +314 −0 staging/native/src/ios/GoogleSignIn.mm
  52. +7 −0 staging/native/testapp/LaunchScreen.storyboard
  53. +7 −0 staging/native/testapp/Podfile
  54. +110 −0 staging/native/testapp/build.gradle
  55. BIN staging/native/testapp/gradle/wrapper/gradle-wrapper.jar
  56. +6 −0 staging/native/testapp/gradle/wrapper/gradle-wrapper.properties
  57. +172 −0 staging/native/testapp/gradlew
  58. +84 −0 staging/native/testapp/gradlew.bat
  59. +22 −0 staging/native/testapp/src/android/AndroidManifest.xml
  60. +57 −0 staging/native/testapp/src/android/CMakeLists.txt
  61. +254 −0 staging/native/testapp/src/android/android_main.cpp
  62. +55 −0 staging/native/testapp/src/android/java/com/google/signin/testapp/LoggingUtils.java
  63. +106 −0 staging/native/testapp/src/android/java/com/google/signin/testapp/TextEntryField.java
  64. +17 −0 staging/native/testapp/src/android/res/layout/main.xml
  65. +4 −0 staging/native/testapp/src/android/res/values/strings.xml
  66. +81 −0 staging/native/testapp/src/common_main.cpp
  67. +174 −0 staging/native/testapp/src/ios/ios_main.mm
  68. +54 −0 staging/native/testapp/src/main.h
  69. +378 −0 staging/native/testapp/testapp.xcodeproj/project.pbxproj
  70. +93 −0 staging/native/testapp/testapp.xcodeproj/xcshareddata/xcschemes/testapp.xcscheme
  71. +98 −0 staging/native/testapp/testapp/Images.xcassets/AppIcon.appiconset/Contents.json
  72. +51 −0 staging/native/testapp/testapp/Images.xcassets/LaunchImage.launchimage/Contents.json
  73. +39 −0 staging/native/testapp/testapp/Info.plist
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.gradle/
.idea/
.vscode/
bin/
build/
*.iml
@@ -23,3 +24,10 @@ GoogleSignInPlugin/Assets/Plugins/iOS/client*.plist*

Assembly-CSharp-Editor.csproj
Assembly-CSharp.csproj

# don't check in the binaries that are built (for now)
staging/native/google-signin-cpp

# don't check in iOS pod generated content
contents.xcworkspacedata
staging/native/testapp/testapp.xcodeproj/project.xcworkspace/xcuserdata
Original file line number Diff line number Diff line change
@@ -3,36 +3,11 @@
<!-- See https://github.com/googlesamples/unity-jar-resolver#usage for
how to configure dependencies -->
<androidPackages>
<!-- Internal library dependency. -->
<androidPackage spec="com.google.signin:google-signin-support:1+">
<repositories>
<repository>Assets/GoogleSignIn/Editor/m2repository</repository>
</repositories>
</androidPackage>
<!--- Auth THIS IS ALWAYS REQUIRED -->
<!-- The dependency is actually on 10.2, but 10+ is close enough.
If you have problems, please change this to a concrete value.
-->
<androidPackage spec="com.google.android.gms:play-services-auth:10+">
<androidSdkPackageIds>
<androidSdkPackageId>extra-google-m2repository</androidSdkPackageId>
</androidSdkPackageIds>
</androidPackage>

<!-- IF YOU ARE USING THE GAMES_CONFIG TO SIGN-IN, YOU NEED TO
UNCOMMENT THIS DEPENDENCY!!
This is only used if you need to add play-services-games to your
project.
-->
<!--
<androidPackage spec="com.google.android.gms:play-services-games:10+">
<androidPackage spec="com.google.android.gms:play-services-auth:16+">
<androidSdkPackageIds>
<androidSdkPackageId>extra-google-m2repository</androidSdkPackageId>
</androidSdkPackageIds>
</androidPackage>
-->

</androidPackages>

<!-- iOS Cocoapod dependencies can be specified by each iosPod element. -->

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
Assets/GoogleSignIn/Editor/GoogleSignInDependencies.xml
Assets/GoogleSignIn/Editor/m2repository/com/google/signin/google-signin-support/1.0.1/google-signin-support-1.0.1.aar
Assets/GoogleSignIn/Editor/m2repository/com/google/signin/google-signin-support/1.0.1/google-signin-support-1.0.1.aar.md5
Assets/GoogleSignIn/Editor/m2repository/com/google/signin/google-signin-support/1.0.1/google-signin-support-1.0.1.aar.sha1
Assets/GoogleSignIn/Editor/m2repository/com/google/signin/google-signin-support/1.0.1/google-signin-support-1.0.1.pom
Assets/GoogleSignIn/Editor/m2repository/com/google/signin/google-signin-support/1.0.1/google-signin-support-1.0.1.pom.md5
Assets/GoogleSignIn/Editor/m2repository/com/google/signin/google-signin-support/1.0.1/google-signin-support-1.0.1.pom.sha1
Assets/GoogleSignIn/Future.cs
Assets/GoogleSignIn/GoogleSignIn.cs
Assets/GoogleSignIn/GoogleSignInConfiguration.cs
Assets/GoogleSignIn/GoogleSignInStatusCode.cs
Assets/GoogleSignIn/GoogleSignInUser.cs
Assets/GoogleSignIn/Impl/BaseObject.cs
Assets/GoogleSignIn/Impl/GoogleSignInImpl.cs
Assets/GoogleSignIn/Impl/NativeFuture.cs
Assets/GoogleSignIn/Impl/SignInHelperObject.cs
Assets/Parse/LICENSE
Assets/Parse/Plugins/Unity.Compat.dll
Assets/Parse/Plugins/Unity.Tasks.dll
Assets/PlayServicesResolver/Editor/Google.IOSResolver_v1.2.54.0.dll
Assets/PlayServicesResolver/Editor/Google.JarResolver_v1.2.54.0.dll
Assets/PlayServicesResolver/Editor/Google.VersionHandler.dll
Assets/PlayServicesResolver/Editor/Google.VersionHandlerImpl_v1.2.54.0.dll
Assets/PlayServicesResolver/Editor/play-services-resolver_v1.2.54.0.txt
Assets/Plugins/Android/native-googlesignin-release.aar
Assets/Plugins/iOS/GoogleSignIn/GoogleSignInAppController.h
Assets/Plugins/iOS/GoogleSignIn/GoogleSignInAppController.mm

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion GoogleSignInPlugin/Assets/GoogleSignIn/GoogleSignIn.cs
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ static GoogleSignIn() {
public static GoogleSignInConfiguration Configuration {
set {
// Can set the configuration until the singleton is created.
if (theInstance == null || theConfiguration == value) {
if (theInstance == null || theConfiguration == value || theConfiguration == null) {
theConfiguration = value;
} else {
throw new SignInException(GoogleSignInStatusCode.DeveloperError,
@@ -141,6 +141,7 @@ public Task<GoogleSignInUser> SignInSilently() {
/// account to use when signing in.
/// </remarks>
public void SignOut() {
theConfiguration = null;
impl.SignOut();
}

10 changes: 8 additions & 2 deletions GoogleSignInPlugin/Assets/GoogleSignIn/Impl/NativeFuture.cs
Original file line number Diff line number Diff line change
@@ -65,10 +65,16 @@ public GoogleSignInUser Result {
GoogleSignInImpl.GoogleSignIn_GetIdToken(userPtr, out_string,
out_size));

user.AuthCode = OutParamsToString((out_string, out_size) =>
GoogleSignInImpl.GoogleSignIn_GetServerAuthCode(userPtr, out_string,
out_size));

string url = OutParamsToString((out_string, out_size) =>
GoogleSignInImpl.GoogleSignIn_GetImageUrl(userPtr, out_string,
out_size));
user.ImageUrl = new System.Uri(url);
if (url.Length > 0) {
user.ImageUrl = new System.Uri(url);
}

user.UserId = OutParamsToString((out_string, out_size) =>
GoogleSignInImpl.GoogleSignIn_GetUserId(userPtr, out_string,
@@ -93,4 +99,4 @@ public GoogleSignInStatusCode Status {
}
}
}
}
}
20 changes: 20 additions & 0 deletions GoogleSignInPlugin/Assets/Plugins/iOS/GoogleSignIn/GoogleSignIn.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/**
* Copyright 2017 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#import <GoogleSignIn/GIDSignIn.h>
@interface GoogleSignInHandler
: NSObject <GIDSignInDelegate, GIDSignInUIDelegate>

@end

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading