Br 4321 removed changes for model garden#103
Conversation
Summary of ChangesHello @bhandarivijay-png, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing several Jupyter notebooks by migrating Google Cloud Storage operations from the older Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several notebooks to replace gsutil commands with their gcloud storage equivalents and removes some unused imports. While this is a good modernization effort, I've found a recurring critical issue across all modified notebooks where the gcloud storage buckets create command is used with incorrect syntax. The bucket name/URI must precede any flags. I've left specific suggestions for each occurrence. Please address these to ensure the notebooks run correctly.
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_NAME" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION $BUCKET_NAME" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket name should precede the flags.
! gcloud storage buckets create $BUCKET_NAME --location=$REGION
| "source": [ | ||
| "! gsutil mb -l $REGION gs://$BUCKET_NAME" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION gs://$BUCKET_NAME" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket name should precede the flags.
! gcloud storage buckets create gs://$BUCKET_NAME --location=$REGION
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location $REGION $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket URI should precede the flags, and the --location flag is missing an equals sign.
! gcloud storage buckets create $BUCKET_URI --location=$REGION
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket URI should precede the flags.
! gcloud storage buckets create $BUCKET_URI --location=$REGION
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location $REGION $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket URI should precede the flags, and the --location flag is missing an equals sign.
! gcloud storage buckets create $BUCKET_URI --location=$REGION
| "source": [ | ||
| "! gsutil mb -l $REGION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location=$REGION $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket URI should precede the flags.
! gcloud storage buckets create $BUCKET_URI --location=$REGION
| "source": [ | ||
| "! gsutil mb -l $LOCATION $BUCKET_URI" | ||
| ] | ||
| "! gcloud storage buckets create --location $LOCATION $BUCKET_URI" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket URI should precede the flags, and the --location flag is missing an equals sign.
! gcloud storage buckets create $BUCKET_URI --location=$LOCATION
| "source": [ | ||
| "! gsutil mb -l {LOCATION} -p {PROJECT_ID} {BUCKET_URI}" | ||
| ] | ||
| "! gcloud storage buckets create --location={LOCATION} --project={PROJECT_ID} {BUCKET_URI}" ] |
There was a problem hiding this comment.
The gcloud storage buckets create command has incorrect syntax. The bucket URI should precede the flags.
! gcloud storage buckets create {BUCKET_URI} --location={LOCATION} --project={PROJECT_ID}
2 participants
Removed changes for model garden