removed changes for model garden pr#4337 #75

bhandarivijay-png · 2025-12-22T10:42:38Z

comment

This reverts commit 3ef23f1.

This reverts commit 7534760.

This reverts commit f497568.

gemini-code-assist · 2025-12-22T10:43:06Z

Summary of Changes

Hello @bhandarivijay-png, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the Google Cloud Storage interactions within several Jupyter notebooks. It systematically replaces all gsutil command-line calls with their gcloud storage counterparts, aligning the notebooks with current Google Cloud CLI best practices. This ensures that the examples and workflows presented in these notebooks remain up-to-date and functional with the latest tooling.

Highlights

Migration to gcloud storage commands: All instances of gsutil commands within the affected Jupyter notebooks have been replaced with their equivalent gcloud storage commands. This includes operations for creating, listing, copying, reading, and deleting Google Cloud Storage buckets and objects.
Updated IAM policy binding syntax: The gsutil iam ch command for managing IAM policies on buckets has been updated to use gcloud storage buckets add-iam-policy-binding, reflecting the modern approach for IAM management in gcloud storage.
Enhanced error handling for bucket deletion: In one instance, the bucket deletion command was updated to include --continue-on-error, providing more robust cleanup behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request consistently migrates gsutil commands to the recommended gcloud storage commands across several Jupyter notebooks. The changes are correct and improve the notebooks by using the modern toolchain. My review focuses on ensuring consistency in the command-line syntax for the new gcloud commands to improve readability and maintainability across the codebase. Specifically, I've suggested using a space to separate flags and their values, which is a more common convention.

gemini-code-assist · 2025-12-22T10:47:30Z

notebooks/community/gapic/automl/showcase_automl_video_action_recognition_batch.ipynb

      "source": [
-        "! gsutil mb -l $REGION $BUCKET_NAME"
-      ]
+        "! gcloud storage buckets create --location=$REGION $BUCKET_NAME"      ]


For consistency with other notebooks in this PR and common gcloud command style, it's better to use a space instead of an equals sign to separate the flag and its value. While both are valid, a consistent style improves readability.

! gcloud storage buckets create --location $REGION $BUCKET_NAME

gemini-code-assist · 2025-12-22T10:47:30Z

notebooks/community/migration/UJ2,12 legacy Custom Training Prebuilt Container TF Keras.ipynb

      "source": [
-        "! gsutil mb -l $REGION gs://$BUCKET_NAME"
-      ]
+        "! gcloud storage buckets create --location=$REGION gs://$BUCKET_NAME"      ]


For consistency with other notebooks in this PR and common gcloud command style, it's better to use a space instead of an equals sign to separate the flag and its value. While both are valid, a consistent style improves readability.

! gcloud storage buckets create --location $REGION gs://$BUCKET_NAME

gemini-code-assist · 2025-12-22T10:47:30Z

notebooks/community/ml_ops/stage7/get_started_with_model_monitoring_custom_tf_serving.ipynb

      "source": [
-        "! gsutil mb -l $REGION $BUCKET_URI"
-      ]
+        "! gcloud storage buckets create --location=$REGION $BUCKET_URI"      ]


For consistency with other notebooks in this PR and common gcloud command style, it's better to use a space instead of an equals sign to separate the flag and its value. While both are valid, a consistent style improves readability.

! gcloud storage buckets create --location $REGION $BUCKET_URI

gemini-code-assist · 2025-12-22T10:47:30Z

notebooks/community/model_garden/model_garden_axolotl_qwen3_finetuning.ipynb

        "    BUCKET_NAME = \"/\".join(BUCKET_URI.split(\"/\")[:3])\n",
-        "    ! gsutil mb -l {REGION} {BUCKET_URI}\n",
-        "else:\n",
+        "    ! gcloud storage buckets create --location={REGION} {BUCKET_URI}\n",        "else:\n",


For consistency with other notebooks in this PR and common gcloud command style, it's better to use a space instead of an equals sign to separate the flag and its value. While both are valid, a consistent style improves readability.

! gcloud storage buckets create --location {REGION} {BUCKET_URI}

gemini-code-assist · 2025-12-22T10:47:30Z

...mmunity/vertex_endpoints/optimized_tensorflow_runtime/bert_optimized_online_prediction.ipynb

      "source": [
-        "! gsutil mb -l $REGION -p $PROJECT_ID $BUCKET_URI"
-      ]
+        "! gcloud storage buckets create --location=$REGION --project=$PROJECT_ID $BUCKET_URI"      ]


For consistency with other notebooks in this PR and common gcloud command style, it's better to use a space instead of an equals sign to separate flags and their values. While both are valid, a consistent style improves readability.

! gcloud storage buckets create --location $REGION --project $PROJECT_ID $BUCKET_URI

gemini-code-assist · 2025-12-22T10:47:30Z

notebooks/official/training/sdk_pytorch_torchrun_custom_container_training_imagenet.ipynb

      "source": [
-        "! gsutil mb -l {LOCATION} -p {PROJECT_ID} {BUCKET_URI}"
-      ]
+        "! gcloud storage buckets create --location={LOCATION} --project={PROJECT_ID} {BUCKET_URI}"      ]


For consistency with other notebooks in this PR and common gcloud command style, it's better to use a space instead of an equals sign to separate flags and their values. While both are valid, a consistent style improves readability.

! gcloud storage buckets create --location {LOCATION} --project {PROJECT_ID} {BUCKET_URI}

googlyrahman and others added 12 commits October 17, 2025 18:26

Migrate gsutil usage to gcloud storage

28b7b27

Manual Changes

3ef23f1

Manual Changes

64878cd

Manual Changes

66fa8e0

Manual Changes

87ead6a

Revert "Manual Changes"

9a8d1d1

This reverts commit 3ef23f1.

Manaul Changes

720e762

Changes for 4337

f497568

Fix: Resolved linter errors and formatted notebooks

7534760

Revert "Fix: Resolved linter errors and formatted notebooks"

6f7c113

This reverts commit 7534760.

Revert "Changes for 4337"

f47afcf

This reverts commit f497568.

Changes for 4337

b850cab

gemini-code-assist bot reviewed Dec 22, 2025

View reviewed changes

bhandarivijay-png changed the title ~~Model garden 4337~~ removed changes for model garden pr#4337 Dec 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removed changes for model garden pr#4337 #75

removed changes for model garden pr#4337 #75

Uh oh!

bhandarivijay-png commented Dec 22, 2025

Uh oh!

gemini-code-assist bot commented Dec 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

gemini-code-assist bot Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

removed changes for model garden pr#4337 #75

Are you sure you want to change the base?

removed changes for model garden pr#4337 #75

Uh oh!

Conversation

bhandarivijay-png commented Dec 22, 2025

Uh oh!

gemini-code-assist bot commented Dec 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants