Model garden4339 by bhandarivijay-png · Pull Request #78 · googlyrahman/vertex-ai-samples

bhandarivijay-png · 2025-12-22T11:03:41Z

chenges has done gcloud to gsutil

This reverts commit a7a7bda.

This reverts commit 71c777d.

gemini-code-assist · 2025-12-22T11:04:11Z

Summary of Changes

Hello @bhandarivijay-png, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates various Jupyter notebooks to align with current best practices for interacting with Google Cloud Storage by migrating from the older gsutil command-line interface to the gcloud storage CLI. The changes ensure that the notebooks use the recommended and more integrated Google Cloud command set, improving future compatibility and consistency. Additionally, minor code formatting and import optimizations were performed to enhance code quality.

Highlights

Command Line Tool Migration: Replaced all instances of the gsutil command-line tool with the modern gcloud storage command-line tool across multiple Jupyter notebooks for Google Cloud Storage operations.
Code Formatting Improvements: Applied minor code formatting changes, such as adding trailing commas to function arguments and wrapping long lines, to enhance readability and maintain consistency in Python code within the notebooks.
Import Cleanups: Removed unused imports from google.protobuf.json_format and google.protobuf.struct_pb2 in several notebooks to streamline dependencies.
Notebook Renames: Updated the names of several migration-related notebooks to remove the 'unified' prefix, simplifying their titles.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request aims to migrate gsutil commands to their gcloud storage equivalents across several notebooks. While many of the migrations are correct, I've found several instances where the new gcloud commands have incorrect argument ordering, which will cause them to fail. I've provided suggestions to fix these issues. The pull request also includes numerous stylistic formatting changes, which I have not commented on.

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION $BUCKET_NAME"
+        "! gcloud storage buckets create --location $REGION $BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create $BUCKET_NAME --location $REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION $BUCKET_NAME"
+        "! gcloud storage buckets create --location=$REGION $BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create $BUCKET_NAME --location=$REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION $BUCKET_NAME"
+        "! gcloud storage buckets create --location=$REGION $BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create $BUCKET_NAME --location=$REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION $BUCKET_NAME"
+        "! gcloud storage buckets create --location $REGION $BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create $BUCKET_NAME --location $REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION gs://$BUCKET_NAME"
+        "! gcloud storage buckets create --location $REGION gs://$BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create gs://$BUCKET_NAME --location $REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION gs://$BUCKET_NAME"
+        "! gcloud storage buckets create --location $REGION gs://$BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create gs://$BUCKET_NAME --location $REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l $REGION gs://$BUCKET_NAME"
+        "! gcloud storage buckets create --location $REGION gs://$BUCKET_NAME"


The order of arguments for gcloud storage buckets create is incorrect. The bucket name, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create gs://$BUCKET_NAME --location $REGION

gemini-code-assist · 2025-12-22T11:08:18Z

      "outputs": [],
      "source": [
-        "! gsutil mb -l {REGION} -p {PROJECT_ID} {BUCKET_URI}"
+        "! gcloud storage buckets create --location={REGION} --project={PROJECT_ID} {BUCKET_URI}"


The order of arguments for gcloud storage buckets create is incorrect. The bucket URI, which is a positional argument, must be specified before flags like --location and --project.

! gcloud storage buckets create {BUCKET_URI} --location={REGION} --project={PROJECT_ID}

gemini-code-assist · 2025-12-22T11:08:18Z

        "    BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}-{str(uuid.uuid4())[:4]}\"\n",
        "    BUCKET_NAME = \"/\".join(BUCKET_URI.split(\"/\")[:3])\n",
-        "    ! gsutil mb -l {REGION} {BUCKET_URI}\n",
+        "    ! gcloud storage buckets create --location={REGION} {BUCKET_URI}\n",


The order of arguments for gcloud storage buckets create is incorrect. The bucket URI, which is a positional argument, must be specified before flags like --location.

! gcloud storage buckets create {BUCKET_URI} --location={REGION}

gemini-code-assist · 2025-12-22T11:08:18Z

        "else:\n",
        "    assert BUCKET_URI.startswith(\"gs://\"), \"BUCKET_URI must start with `gs://`.\"\n",
-        "    shell_output = ! gsutil ls -Lb {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n",
+        "    shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n",


The --full flag is not a valid option for gcloud storage ls. To get the bucket's location, you should use gcloud storage buckets describe. The subsequent grep and sed commands also need to be updated to parse the new output format.

shell_output = ! gcloud storage buckets describe {BUCKET_NAME} | grep "location:" | sed "s/location: //"

googlyrahman and others added 17 commits October 17, 2025 19:34

Migrate gsutil usage to gcloud storage

d84ae4f

Manual Changes

5d897fd

Manual Changes

71c777d

Fix: Updated gcloud storage command without formatting

eed921b

Manual Changes

fd8bb16

Manual Changes

a7a7bda

Revert "Manual Changes"

3f68933

This reverts commit a7a7bda.

Manual Changes

3959c2b

Revert "Manual Changes"

5c2c3f9

This reverts commit a7a7bda.

Manual Changes

8bd0d77

Revert "Manual Changes"

501a589

This reverts commit 71c777d.

Manual Changes

d44e3b1

Manual changes

46fb663

Changes for 4339

ce16436

Changes for 4339

e86ab07

Changes for 4339

9e18216

Fix: Applied linter formatting and resolved style issues

3908d9e

gemini-code-assist Bot reviewed Dec 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Model garden4339#78

Model garden4339#78
bhandarivijay-png wants to merge 17 commits into
googlyrahman:mainfrom
bhandarivijay-png:model-garden4339

bhandarivijay-png commented Dec 22, 2025

Uh oh!

gemini-code-assist Bot commented Dec 22, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bhandarivijay-png commented Dec 22, 2025

Uh oh!

gemini-code-assist Bot commented Dec 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants