Skip to content

Kadai1 marltake #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Kadai1 marltake #14

wants to merge 2 commits into from

Conversation

marltake
Copy link

@marltake marltake commented Sep 9, 2019

動きそうなところまでできたので、一旦提出します

@marltake marltake added the kadai1 label Sep 9, 2019
marltake
marltake commented Sep 9, 2019
View reviewed changes
Copy link
Author

@marltake marltake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

講義の内容に沿って変更するべき部分

kadai1/marltake/convert/convert.go
if targets[0] != targets[1] && allowedExt[targets[0]] && allowedExt[targets[1]] {
return targets[0], targets[1], true
}
return "", "", false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

名前付きリターンを使うなら、src, dest, ok に代入して return で返すべき

kadai1/marltake/main.go
"log"
"path/filepath"

"./convert"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相対 import は不可になる。

@marltake marltake mentioned this pull request Sep 9, 2019
Open
@marltake marltake removed the kadai1 label Sep 9, 2019
@marltake
Copy link
Author

marltake commented Sep 9, 2019

#15 で出し直しました。

@marltake marltake closed this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marltake