kadai1-shinta #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
reviewed
Sep 9, 2019
|
|
||
| // judgeArgExt は引数に設定された拡張子が変換可能なものか判別する | ||
| func judgeArgExt(preExt string, afterExt string) (err error) { | ||
| allowExtList := []string{"jpg", "jpeg", "png", "gif"} |
tenntenn
reviewed
Sep 9, 2019
| } | ||
| } | ||
| if !judgeExtFlag { | ||
| err = errors.New("指定できる拡張子:" + strings.Join(allowExtList, ",")) |
tenntenn
reviewed
Sep 9, 2019
| } | ||
|
|
||
| targetImg.Close() | ||
| outputImg.Close() |
tenntenn
reviewed
Sep 9, 2019
|
|
||
| targetImg.Close() | ||
| outputImg.Close() | ||
| return |
tenntenn
reviewed
Sep 9, 2019
| */ | ||
| func convertImages(dir string, preExt string, afterExt string) (err error) { | ||
| // 変換対象ファイルが jpeg or jpg かを確認する | ||
| jpgType := [2]string{".jpg", ".jpeg"} |
There was a problem hiding this comment.
jpgType := map[string]bool{".jpg", ".jpeg"} なら if jpgType[preExt] {} で判断できる
There was a problem hiding this comment.
コメントに記載のvalue無しではなく、下記のように宣言するということであってますでしょうか？(missing key in map literal エラーになるので）
jpgType := map[string]bool{".jpg": ture, ".jpeg": true}
tenntenn
reviewed
Sep 9, 2019
| if err != nil { | ||
| return err | ||
| } | ||
| // jpeg は jpgも変換対象とする |
There was a problem hiding this comment.
以下、すべて対象
jpg -> jpg
jpeg -> jpeg
jpg -> jpeg
jpeg -> jpg
tenntenn
reviewed
Sep 9, 2019
| } | ||
| return nil | ||
| }) | ||
| return |
tenntenn
reviewed
Sep 9, 2019
| func main() { | ||
| err := imageconversion.Excute() | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題1
次の仕様を満たすコマンドを作って下さい
ディレクトリを指定する
指定したディレクトリ以下のJPGファイルをPNGに変換（デフォルト）
ディレクトリ以下は再帰的に処理する
変換前と変換後の画像形式を指定できる（オプション）
以下を満たすように開発してください
mainパッケージと分離する
自作パッケージと標準パッケージと準標準パッケージのみ使う
ユーザ定義型を作ってみる
GoDocを生成してみる
使い方