Kadai1 segakazzz #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2020 21:48
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/.gitignore
Outdated
| @@ -0,0 +1,7 @@ | |||
| .idea | |||
| image/in/* | |||
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| dir = flag.String("d", ".", "Indicate directory to convert") | ||
| in = flag.String("i", "jpg", "Indicate input image file's extension") | ||
| out = flag.String("o", "png", "Indicate output image file's extension") | ||
| err error |
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| flag.Parse() | ||
| c, err := newConverter(*dir, *in, *out) | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
log.Fatalは内部で、os.Exit(1)を呼んでいます。
そのため、終了コードを自分で決められないので、fmt.Fprintln(os.Stderr, ....)とos.Exitを自分で呼んだ方が良いです。
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| case "jpg", "png": | ||
| input = strings.ToLower(input) | ||
| default: | ||
| return &converter{}, fmt.Errorf("Input extension is not valid. Select one from jpg/png") |
There was a problem hiding this comment.
エラーの際は最後の戻り値以外はゼロ値（この場合はポインタなのでnil）を返す。
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| } | ||
|
|
||
| // Convert method converts all jpg files in dirname to png. "out" folder is generated if it doesn't exist. | ||
| func (c *converter) Convert() (e error) { |
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| func (c *converter) getSourceFiles() ([]os.FileInfo, error) { | ||
| files, err := ioutil.ReadDir(c.dirname) | ||
| if err != nil { | ||
| return []os.FileInfo{}, err |
tenntenn
reviewed
Jul 6, 2020
| return nil | ||
| } | ||
|
|
||
| func (c *converter) convertSingle(filename string) (e error) { |
There was a problem hiding this comment.
何をreturnしたか追いづらいので、名前付き戻り値はできるだけ使わない。
tenntenn
reviewed
Jul 6, 2020
| func (c *converter) convertSingle(filename string) (e error) { | ||
| input := filepath.Join(c.dirname, filename) | ||
| outDir := filepath.Join(c.dirname, "out") | ||
| output := filepath.Join(outDir, strings.Replace(strings.ToLower(filename), "."+c.input, "."+c.output, -1)) |
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| os.Mkdir(outDir, 0755) | ||
| } | ||
|
|
||
| in, _ := os.Open(input) |
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| return | ||
| } | ||
| } | ||
| defer in.Close() |
tenntenn
reviewed
Jul 6, 2020
kadai1/segakazzz/imgconv/imgconv.go
Outdated
| } | ||
| } | ||
| defer in.Close() | ||
| defer out.Close() |
added 7 commits
July 10, 2020 17:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題１のレビューをお願い致します。
main packageでどこまで記述して、自作パッケージにどこまでの内容を切り出すべきか判断がよくわかっていないので、良い書き方があればコメント頂けると幸いです。
その他はkadai1/segakazzz/README.mdをご参照ください。