Revert "Implement register-based closure ctx"#1614
Conversation
|
Note The number of changes in this pull request is too large for Gemini Code Assist to generate a summary. |
Code Review SummaryThis revert of PR #1599 is clean and complete. The PR properly removes the register-based closure context passing and returns to the parameter-based approach. The documentation in No critical issues found. The code quality is good, and the changes are consistent throughout. Minor SuggestionsTwo potential improvements in the newly added runtime functions:
These are minor optimizations and don't block the revert. |
| return true | ||
| } | ||
|
|
||
| func arrayequal(t, p, q unsafe.Pointer) bool { |
There was a problem hiding this comment.
Consider adding a pointer equality fast path for the common case where the same array is compared to itself:
| func arrayequal(t, p, q unsafe.Pointer) bool { | |
| func arrayequal(t, p, q unsafe.Pointer) bool { | |
| if p == q { | |
| return true | |
| } | |
| x := (*arraytype)(t) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
+ Coverage 90.51% 91.06% +0.55%
==========================================
Files 48 45 -3
Lines 12077 11938 -139
==========================================
- Hits 10931 10871 -60
+ Misses 956 892 -64
+ Partials 190 175 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #1599