Skip to content
This repository was archived by the owner on Sep 6, 2018. It is now read-only.

bugfix, return err when readConf() failed - #228

Open
wankai wants to merge 1 commit into
goraft:masterfrom
wankai:master
Open

bugfix, return err when readConf() failed#228
wankai wants to merge 1 commit into
goraft:masterfrom
wankai:master

Conversation

@wankai

@wankai wankai commented Jun 28, 2014

Copy link
Copy Markdown

an obviously bug in readConf() function

@philips

philips commented Jul 29, 2014

Copy link
Copy Markdown
Member

lgtm. @xiangli-cmu @unihorn ?

@yichengq

Copy link
Copy Markdown
Contributor

I guess it might want to filter out io.ErrNotExist.
@xiangli-cmu

@wankai

wankai commented Aug 1, 2014

Copy link
Copy Markdown
Author

@unihorn , config is as follow. if config file doesn't exist, peers will be nil, then this raft server will have no idea of others.

type Config struct {
    CommitIndex uint64 `json:"commitIndex"`
    // TODO decide what we need to store in peer struct
    Peers []*Peer `json:"peers"`
}

@yichengq

yichengq commented Aug 1, 2014

Copy link
Copy Markdown
Contributor

@wankai It may be a new raft machine, and doesn't have that file yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants