Add follow_symlink argument to Inotify observer #1086
Merged
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoboTiG
reviewed
Nov 12, 2024
Collaborator
BoboTiG
left a comment
BoboTiG
left a comment
There was a problem hiding this comment.
Nice, thank you @Corentin-pro!
Would you mind adding a line in the changelog also, please?
* Improve link test in inotify_c.py
Contributor
Author
|
@BoboTiG I ran tox (fixed some code format) and find the mypy issue, the added I don't know what should I add in the changelog, I couldn't find examples in previous PR. |
TobiasRzepka
pushed a commit
to TobiasRzepka/watchdog
that referenced
this pull request
Apr 19, 2025
…khargosh#1086) * Add follow_symlink argument to Inotify observer * Fix FSEventObserver (add follow_symlink kwarg) * Improve link test in inotify_c.py --------- Co-authored-by: Corentin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
follow_symlinkas keyword argument allow to have recursive watch consistent with the polling method.This makes the change from PR #109 the default behavior but not the only option. The default values being
Falsethis changes will not change nor break any previous use of the library.Fixes #365.
Ruff is OK and 2 tests are not passing (were not passing before changes either on my computer):
threading.active_count() == old_thread_count->assert 1 == 2stack.enter_context(open(path))->OSError: [Errno 24] Too many open files: '/tmp/[...]/pytest-1/test_select_fd0/new_file', my ulimit isunlimited