Reduce number of created inotify instances #275 #1099
Merged
+1,102
−731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otify_watch_group.py
Collaborator
|
Wow! Let me some time to properly review in depth this PR <3 |
Collaborator
|
Given that is a major breaking change, https://pypistats.org/packages/watchdog metrics, and upcoming 3.9 EOL (https://devguide.python.org/versions/), I would be OK to drop Python 3.9 at the same time if it eases your work. |
Contributor
Author
|
I don't think we need to drop 3.9 compatibility (yet). |
Collaborator
|
Thanks @JoachimCoenen 🥂 |
TobiasRzepka
pushed a commit
to TobiasRzepka/watchdog
that referenced
this pull request
Oct 11, 2025
…akhargosh#1099) * re: gorakhargosh#275 reduced number of created inotify instances - first draft * re: gorakhargosh#275 fixed race conditions from inotify * re: gorakhargosh#275 fixed test_inotify_c.py * re: gorakhargosh#275 fixed test_inotify_buffer.py * re: gorakhargosh#275 renamed test_inotify_buffer.py to test_inotify_watch.py * re: gorakhargosh#275 ignore error when removing a watch that doesn't exist anymore * re: gorakhargosh#275 fixed some docstrings * re: gorakhargosh#275 renamed InotifyBuffer to InotifyMoveEventGrouper * re: gorakhargosh#275 renamed InotifyWatch to InotifyWatchGroup * re: gorakhargosh#275 added clarifying comments * re: gorakhargosh#275 added test case for independence of InotifyWatchGroups * re: gorakhargosh#275 renamed test_inotify_watch_grouper.py to test_inotify_watch_group.py * re: gorakhargosh#275 removed superfluous todos * re: gorakhargosh#275 fixed too early import in test * re: gorakhargosh#275 fixed python 3.9 compatibility * re: gorakhargosh#275 fixed python 3.9 compatibility * re: gorakhargosh#275 fixed linter issues
TobiasRzepka
pushed a commit
to TobiasRzepka/watchdog
that referenced
this pull request
Oct 11, 2025
…akhargosh#1099) * re: gorakhargosh#275 reduced number of created inotify instances - first draft * re: gorakhargosh#275 fixed race conditions from inotify * re: gorakhargosh#275 fixed test_inotify_c.py * re: gorakhargosh#275 fixed test_inotify_buffer.py * re: gorakhargosh#275 renamed test_inotify_buffer.py to test_inotify_watch.py * re: gorakhargosh#275 ignore error when removing a watch that doesn't exist anymore * re: gorakhargosh#275 fixed some docstrings * re: gorakhargosh#275 renamed InotifyBuffer to InotifyMoveEventGrouper * re: gorakhargosh#275 renamed InotifyWatch to InotifyWatchGroup * re: gorakhargosh#275 added clarifying comments * re: gorakhargosh#275 added test case for independence of InotifyWatchGroups * re: gorakhargosh#275 renamed test_inotify_watch_grouper.py to test_inotify_watch_group.py * re: gorakhargosh#275 removed superfluous todos * re: gorakhargosh#275 fixed too early import in test * re: gorakhargosh#275 fixed python 3.9 compatibility * re: gorakhargosh#275 fixed python 3.9 compatibility * re: gorakhargosh#275 fixed linter issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #275